Fix error message to fallback to title when detail is missing by Fivell · Pull Request #36 · didww/didww-api-3-java-sdk

Fivell · 2026-03-10T22:36:36Z

Summary

Added getMessage() to ApiError that returns detail if present, otherwise title
Updated buildMessage() to use it

Test plan

6 tests covering detail, title-only, and no-errors scenarios
All tests pass

Copilot

Pull request overview

This PR improves DIDWW API exception messaging by introducing a fallback to the error title when detail is absent, and adds tests to cover the new behavior.

Changes:

Added ApiError#getMessage() to return detail when present, otherwise title
Updated DidwwApiException#buildMessage() to use ApiError#getMessage()
Added unit/integration-style tests covering detail, title-only fallback, and missing errors array scenarios

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
`src/main/java/com/didww/sdk/exception/DidwwApiException.java`	Uses a new `ApiError#getMessage()` fallback to build clearer exception messages
`src/test/java/com/didww/sdk/exception/DidwwApiExceptionTest.java`	Adds coverage for `detail` vs `title` fallback and no-errors responses

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-10T22:40:19Z

src/test/java/com/didww/sdk/exception/DidwwApiExceptionTest.java

+import java.util.List;
+


Unused import java.util.List is added but not referenced anywhere in this test class; please remove it to keep the test sources clean and avoid compiler warnings.

Suggested change

import java.util.List;

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-11T08:09:39Z

src/main/java/com/didww/sdk/exception/DidwwApiException.java

            sb.append(": ");
            for (int i = 0; i < errors.size(); i++) {
                if (i > 0) sb.append("; ");
-                sb.append(errors.get(i).getDetail());
+                sb.append(errors.get(i).getMessage());
            }


ApiError#getMessage() can return null (e.g., when both detail and title are missing), and StringBuilder.append(null) will append the literal string "null" into the exception message. Consider skipping null/blank error messages in buildMessage() or providing a fallback (e.g., status/code or a generic placeholder) to avoid confusing exception messages.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-11T09:52:40Z

src/main/java/com/didww/sdk/exception/DidwwApiException.java

+        public String getMessage() {
+            if (detail != null) return detail;
+            if (title != null) return title;
+            return "Unknown error";


ApiError#getMessage() introduces a new Jackson bean property named message. Since the SDK ObjectMapper disables FAIL_ON_UNKNOWN_PROPERTIES, an errors[].message field would previously be ignored but may now fail deserialization because this property has no setter/field. Consider marking this helper with @JsonIgnore (as done for other helper getters) or @JsonProperty(access = READ_ONLY) so it won’t participate in JSON mapping.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-11T10:01:40Z

src/main/java/com/didww/sdk/exception/DidwwApiException.java

+        /**
+         * Returns {@code detail} if present, otherwise falls back to {@code title},
+         * or {@code "Unknown error"} when both are absent.
+         */
+        public String getMessage() {
+            if (detail != null) return detail;
+            if (title != null) return title;
+            return "Unknown error";
+        }


ApiError#getMessage() is a derived/computed value; leaving it as a standard getter will make Jackson treat it as a real message property during serialization (and potentially during deserialization depending on mapper settings). In this codebase, computed getters (e.g., getType() implementations) are annotated with @JsonIgnore; consider doing the same here to avoid emitting a non-JSON:API field while still allowing callers to use the helper method in Java.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-11T16:34:46Z

src/test/java/com/didww/sdk/exception/DidwwApiExceptionTest.java

+    @Test
+    void testApiErrorGetMessageReturnsDetailOverTitle() {
+        DidwwApiException.ApiError error = new DidwwApiException.ApiError();
+        error.setTitle("Some Title");
+        error.setDetail("Some Detail");
+        assertThat(error.getMessage()).isEqualTo("Some Detail");
+    }
+
+    @Test
+    void testApiErrorGetMessageFallsBackToTitle() {
+        DidwwApiException.ApiError error = new DidwwApiException.ApiError();
+        error.setTitle("Some Title");
+        assertThat(error.getMessage()).isEqualTo("Some Title");
+    }


The new tests cover null/missing detail but don’t cover the case where detail is present but blank/whitespace, which currently prevents fallback to title. Adding a test for blank detail (and optionally blank title) would lock in the intended fallback behavior and catch regressions.

Prevent StringBuilder.append(null) from adding literal "null" string to exception messages by returning "Unknown error" as a fallback in ApiError#getMessage() when both detail and title are absent.

…ssage()

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-11T21:22:33Z

src/main/java/com/didww/sdk/exception/DidwwApiException.java

+        /**
+         * Returns {@code detail} if present, otherwise falls back to {@code title},
+         * or {@code "Unknown error"} when both are absent.
+         */


PR description says getMessage() returns detail if present, otherwise title, but the implementation (and tests) also add a third fallback of "Unknown error" when both are absent. Please update the PR description to reflect this behavior (or drop the extra fallback if it’s not intended).

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

sonarqubecloud · 2026-03-11T21:46:57Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Fivell requested a review from Copilot March 10, 2026 22:37

Copilot started reviewing on behalf of Fivell March 10, 2026 22:38 View session

Fivell force-pushed the fix/error-message-title-fallback branch from 702c1a9 to 138daa7 Compare March 10, 2026 22:39

Copilot AI reviewed Mar 10, 2026

View reviewed changes

Fivell requested a review from Copilot March 11, 2026 08:05

Copilot started reviewing on behalf of Fivell March 11, 2026 08:05 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

Fivell requested a review from Copilot March 11, 2026 09:48

Copilot started reviewing on behalf of Fivell March 11, 2026 09:49 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

Fivell requested a review from Copilot March 11, 2026 09:58

Copilot started reviewing on behalf of Fivell March 11, 2026 09:58 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

Fivell force-pushed the fix/error-message-title-fallback branch from 349c54d to 39f9aa9 Compare March 11, 2026 16:21

Fivell requested a review from Copilot March 11, 2026 16:31

Copilot started reviewing on behalf of Fivell March 11, 2026 16:32 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

Fivell added 4 commits March 11, 2026 22:19

Fix error message to fallback to title when detail is missing

40ed5b0

Remove unused List import in DidwwApiExceptionTest

2808d04

Return fallback message when both detail and title are null in ApiError

0e83987

Prevent StringBuilder.append(null) from adding literal "null" string to exception messages by returning "Unknown error" as a fallback in ApiError#getMessage() when both detail and title are absent.

Add @JsonIgnore to getMessage(), handle null/blank entries in buildMe…

89aca10

…ssage()

Fivell force-pushed the fix/error-message-title-fallback branch from 39f9aa9 to 89aca10 Compare March 11, 2026 21:19

Fivell requested a review from Copilot March 11, 2026 21:19

Copilot started reviewing on behalf of Fivell March 11, 2026 21:20 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

Fivell requested a review from Copilot March 11, 2026 21:24

Copilot started reviewing on behalf of Fivell March 11, 2026 21:25 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

Use plain text body in non-JSON:API error test

bc2a6b9

Fivell merged commit 40d8cf5 into main Mar 11, 2026
5 checks passed

Fivell deleted the fix/error-message-title-fallback branch March 11, 2026 21:47

Conversation

Fivell commented Mar 10, 2026

Summary

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

sonarqubecloud bot commented Mar 11, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants