Fix: Change Balance fields from Double to BigDecimal by Fivell · Pull Request #35 · didww/didww-api-3-java-sdk

Fivell · 2026-03-10T22:22:01Z

Summary

Changed totalBalance, balance, and credit fields from Double to BigDecimal
Ensures precise monetary arithmetic without floating-point errors
Updated tests to use isEqualByComparingTo for BigDecimal comparison

Test plan

BalanceTest verifies all three fields parse correctly as BigDecimal
All tests pass

Copilot

Pull request overview

This PR updates the Balance resource to represent monetary amounts using BigDecimal instead of Double, and adjusts the corresponding test assertions to compare BigDecimal values correctly.

Changes:

Changed totalBalance, balance, and credit in Balance from Double to BigDecimal
Updated BalanceTest assertions to use isEqualByComparingTo with BigDecimal expectations

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
`src/main/java/com/didww/sdk/resource/Balance.java`	Switches balance-related monetary fields and getters from `Double` to `BigDecimal`.
`src/test/java/com/didww/sdk/resource/BalanceTest.java`	Updates assertions to compare `BigDecimal` values rather than floating-point values.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-10T22:25:31Z

src/test/java/com/didww/sdk/resource/BalanceTest.java

 import static org.assertj.core.api.Assertions.assertThat;
 import static com.github.tomakehurst.wiremock.client.WireMock.*;

+import java.math.BigDecimal;
+


Import ordering is inconsistent with the rest of the test suite (e.g., AddressTest groups non-static imports first, then static imports). java.math.BigDecimal should be placed with the other non-static imports above the static imports to match the project’s import style / avoid checkstyle failures.

Suggested change

import static org.assertj.core.api.Assertions.assertThat;

import static com.github.tomakehurst.wiremock.client.WireMock.*;

import java.math.BigDecimal;

import java.math.BigDecimal;

import static org.assertj.core.api.Assertions.assertThat;

import static com.github.tomakehurst.wiremock.client.WireMock.*;

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-11T08:08:35Z

src/main/java/com/didww/sdk/resource/Balance.java

    @JsonProperty("total_balance")
-    private Double totalBalance;
+    private BigDecimal totalBalance;


Changing totalBalance/balance/credit from Double to BigDecimal (and the corresponding getter return types) is a breaking public API change for SDK consumers. Please ensure any in-repo callers (e.g., examples/README snippets) are updated accordingly, and consider providing a backwards-compatible path (e.g., deprecated Double-returning accessors or a documented major version bump/release note) so downstream users aren’t surprised by compilation failures.

Copilot · 2026-03-11T08:08:36Z

src/test/java/com/didww/sdk/resource/BalanceTest.java

 import com.didww.sdk.repository.ApiResponse;
 import org.junit.jupiter.api.Test;
+import java.math.BigDecimal;
+


Import grouping is inconsistent with other tests in this package (they don’t separate regular imports from static imports with an extra blank line). Consider removing the blank line after import java.math.BigDecimal; to keep import formatting consistent.

Suggested change

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-11T10:01:03Z

src/main/java/com/didww/sdk/resource/Balance.java

-    public Double getCredit() {
+    public BigDecimal getCredit() {
        return credit;
    }


Changing the public getter return types from Double to BigDecimal is a breaking API change for SDK consumers (compile-time). If backwards compatibility is required, consider keeping the Double getters (deprecated) or adding alternate getters (e.g., getTotalBalanceAsDouble()) and documenting the migration/release versioning accordingly.

Suggested change

}

}

@Deprecated

public Double getTotalBalanceAsDouble() {

return totalBalance != null ? totalBalance.doubleValue() : null;

}

@Deprecated

public Double getBalanceAsDouble() {

return balance != null ? balance.doubleValue() : null;

}

@Deprecated

public Double getCreditAsDouble() {

return credit != null ? credit.doubleValue() : null;

}

…recision

Move java.math.BigDecimal above static imports to match project conventions.

sonarqubecloud · 2026-03-11T16:23:10Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-11T16:35:32Z

src/main/java/com/didww/sdk/resource/Balance.java

+    public BigDecimal getTotalBalance() {
        return totalBalance;
    }

-    public Double getBalance() {
+    public BigDecimal getBalance() {


Changing these getters from Double to BigDecimal is a source/binary breaking change for SDK consumers (method signature change). If the library intends to remain backward compatible, consider keeping the Double getters (deprecated) and adding new BigDecimal-named accessors, or ensure the release/versioning/docs explicitly treat this as a breaking change.

Fivell requested a review from Copilot March 10, 2026 22:22

Copilot started reviewing on behalf of Fivell March 10, 2026 22:22 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

Fivell requested a review from Copilot March 11, 2026 08:04

Copilot started reviewing on behalf of Fivell March 11, 2026 08:05 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

Fivell requested a review from Copilot March 11, 2026 09:58

Copilot started reviewing on behalf of Fivell March 11, 2026 09:58 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

Fivell added 3 commits March 11, 2026 17:22

Fix Balance fields to use BigDecimal instead of Double for monetary p…

808dace

…recision

Fix import ordering in BalanceTest

bf221fa

Move java.math.BigDecimal above static imports to match project conventions.

Fix import ordering in BalanceTest to match project style

b5637f3

Fivell force-pushed the fix/balance-string-type branch from 4504fc9 to b5637f3 Compare March 11, 2026 16:22

Fivell requested a review from Copilot March 11, 2026 16:31

Copilot started reviewing on behalf of Fivell March 11, 2026 16:32 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

Fivell merged commit b1a48f5 into main Mar 11, 2026
9 checks passed

Fivell deleted the fix/balance-string-type branch March 11, 2026 16:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Change Balance fields from Double to BigDecimal#35

Fix: Change Balance fields from Double to BigDecimal#35
Fivell merged 3 commits intomainfrom
fix/balance-string-type

Fivell commented Mar 10, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 10, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 11, 2026

Uh oh!

Copilot AI Mar 11, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 11, 2026

Uh oh!

sonarqubecloud bot commented Mar 11, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-    }
+    }
+    @Deprecated
+    public Double getTotalBalanceAsDouble() {
+        return totalBalance != null ? totalBalance.doubleValue() : null;
+    }
+    @Deprecated
+    public Double getBalanceAsDouble() {
+        return balance != null ? balance.doubleValue() : null;
+    }
+    @Deprecated
+    public Double getCreditAsDouble() {
+        return credit != null ? credit.doubleValue() : null;
+    }

Conversation

Fivell commented Mar 10, 2026

Summary

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Mar 11, 2026

Quality Gate passed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants