chore(test): Clean up testing guide and Makefile testing dependency checks#9611
Merged
matthewmcneely merged 3 commits intomainfrom Mar 2, 2026
Merged
chore(test): Clean up testing guide and Makefile testing dependency checks#9611matthewmcneely merged 3 commits intomainfrom
matthewmcneely merged 3 commits intomainfrom
Conversation
Add "With make:" examples alongside every go test and ./t command block in TESTING.md, showing how to run the same tests via make test with arguments or dedicated test-* targets. This makes the make interface discoverable inline rather than only in the Quick Start. Remove the "Completed Improvements" section from Future Improvement Ideas — these items are now reflected throughout the guide itself.
Replace the bash listing of test-* targets in Quick Start with a table showing three invocation styles for every target: the dedicated make target, the equivalent make test with arguments, and the direct command without make.
…gement
Rename `make deps` to `make check-deps` with consistent `check-deps-*`
prefixes across scripts and Makefile targets. Add Makefile-level
OS-dispatched `install-deps-*` targets for darwin and linux, a Docker
memory check (`check-docker-available-memory`), and wire `check-deps`
as a prerequisite for all test entry points.
Key changes:
- Rename 7 check scripts: check-{tool}.sh → check-deps-{tool}.sh
- Restructure t/Makefile with three-way check flow (silent pass,
auto-install, or report-and-fail) for each dependency
- Add install-deps-*-darwin targets (all depend on Homebrew check)
- Add install-deps-*-linux targets with package manager detection
- Linux Go install prints instructions instead of auto-installing
(avoids destructive sudo rm -rf /usr/local/go)
- Add check-docker-available-memory.sh (warns if < 8GB, auto-fix
on macOS with AUTO_INSTALL=true)
- Add check-deps prereq to test and test-benchmark targets
- Update TESTING.md references and validation list
github-actions
bot
added
area/testing
mlwelles
changed the title
matthewmcneely
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make deps→make check-depswith consistentcheck-deps-*prefixes across all 7 check scripts and Makefile targetsinstall-deps-*targets for darwin (Homebrew-based) and linux (apt/dnf/pacman detection), replacing script-internal install logiccheck-docker-available-memory) — warns if < 8GB, auto-fixes Docker Desktop settings on macOS whenAUTO_INSTALL=truecheck-depsas prerequisite fortestandtest-benchmarktargets so dependency validation runs for all test pathssudo rm -rf /usr/local/go)make depsreferences, expand validation list, strengthen setup messagingTest plan
make check-depspasses on macOS (local)make check-depspasses on Linux (system-77.local)make setuppasses on macOS (local)make setuppasses on Linux (system-77.local)make check-deps AUTO_INSTALL=truepasses on both platformsmake helpshowscheck-deps(not olddeps)check-go.sh, etc.)