Add an option to load all gists asynchrously#16
Open
knalli wants to merge 1 commit intodflydev:masterfrom
Open
Add an option to load all gists asynchrously#16knalli wants to merge 1 commit intodflydev:masterfrom
knalli wants to merge 1 commit intodflydev:masterfrom
Conversation
Until now, all gist will be load via https://gist.github.com/$id.js which is only a script containing 2 document.write(!). Considering website performance (document.write is a blocker), this change introduce deferred loading of gists. At the moment, this is completely backwards compatible and is *not turned on at default*, because it requires jQuery (jQuery is not included maybe). To enable, just define `EMBED_GISTHUB_DEFERRED` to true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now, all gist will be load via https://gist.github.com/$id.js which is only a script containing 2 document.write(!). Considering website performance (document.write is a blocker), this change introduce deferred loading of gists. At the moment, this is completely backwards compatible and is not turned on at default, because it requires jQuery (jQuery is not included maybe).
To enable, just define
EMBED_GISTHUB_DEFERREDto true.