feat: Stop canisters before upgrading#418
Open
adamspofford-dfinity wants to merge 6 commits intomainfrom
Open
Conversation
Contributor
|
The audit error is fixed in #419 |
lwshang
reviewed
Mar 10, 2026
lwshang
reviewed
Mar 10, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the canister install/upgrade flow so that canisters are stopped before an upgrade and started again afterward, and documents the behavior change in the changelog.
Changes:
- Wrap install execution with stop/start behavior for
Upgrademode. - Add
StopCanister/StartCanistererror variants and warning log for failed restarts. - Update
CHANGELOG.mdto reflect the new upgrade behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
crates/icp-cli/src/operations/install.rs |
Adds stop/start wrapper around install operations during upgrades and introduces new error variants. |
CHANGELOG.md |
Documents the new stop-before-upgrade/start-after behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.