add: Deploy to ICP Ninja + standardize README#1212
Open
jessiemongeon1 wants to merge 3 commits intomasterfrom
Open
add: Deploy to ICP Ninja + standardize README#1212jessiemongeon1 wants to merge 3 commits intomasterfrom
jessiemongeon1 wants to merge 3 commits intomasterfrom
Conversation
Contributor
|
this example is working in ICP-ninja, but I would like to ask if it'd be possible to keep the manual instructions for advanced usage and add ICP-ninja link on top of that for quick start? |
maksymar
reviewed
Jun 27, 2025
| 1. Have a look at the locally running dashboard. The URL is at the end of the `dfx start` command: `Dashboard: http://localhost/...` | ||
| 2. Check out `mat_mat_mul` canister Candid user interface. The URLs are at the end of the `dfx deploy` command: `mat_mat_mul: http://127.0.0.1/?canisterId=...` | ||
|
|
||
| ### Canister interface |
Contributor
There was a problem hiding this comment.
I would keep Further learning and Conclusion section to cover specific methods related to Wasm SIMD instructions.
Contributor
Author
There was a problem hiding this comment.
IMO neither section's content includes anything meaningful. Further learning includes basic dfx start and Candid information, which is not specific to Wasm SIMD, and Conclusion reiterates things covered previously.
The Canister interface subcategory could be restored, but I would not keep either of the others.
maksymar
reviewed
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Why do we need this feature? What are we trying to accomplish?
Requirements
What requirements are necessary to consider this problem solved?
Considered Solutions
What solutions were considered?
Recommended Solution
What solution are you recommending? Why?
Considerations
What impact will this change have on security, performance, users (e.g. breaking changes) or the team (e.g. maintenance costs)?