-
Notifications
You must be signed in to change notification settings - Fork 2.4k
new icon: jwt (original, original-wordmark, plain, plain-wordmark) #2592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@weh Can you tag it with Hacktoberfest? |
|
Hey @Bulani, This Pull Request is incomplete, It Does not contains the wordmark SVG file. JWT Logo also Contains an wordmark in its logo check this |
Added! |
|
Nice. Now also change the title and add original-wordmark in it. |
weh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Bulani, thank you for the contribution. As with your other Pull requests, we need to have (at least) a plain version of the icons. Please also add plain and plain-wordmark versions.
canaleal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the plain and plain-wordmark svgs.
Double check these details before you open a PR
developbranch.devicon.jsonfile at the correct alphabetic position as seen hereThis PR closes #2534
Link to prove your SVG is correct and up-to-date.
https://www.jwt.io/