new icon: aerospike (original, original-wordmark) #2111

inpour · 2024-01-14T14:10:18Z

Double check these details before you open a PR

PR does not match another non-stale PR currently opened
PR name matches the format new icon: Icon name (versions separated by comma). More details here
PR's base is the develop branch.
Your icons are inside a folder as seen here
SVG matches the standards laid out here
A new object is added in the devicon.json file as seen here

This PR closes #2110

Link to prove your SVG is correct and up-to-date.

https://aerospike.com/

canaleal

Thank you for the contribution! Here are some changes that can be made to improve the PR:

Using Aliases

Because the aerospike-original.svg only has 1 path and a simple fill color #c21417, it can be used as a stand in (Alias) for the plain version.

More info about how to use aliases can be found here.

canaleal

Just a handful of small suggestions.

If you'd like to optimize the SVGs, please follow the steps in this tutorial

devicon.json

canaleal

Great work!

Because you used an alias, you can now delete the aerospike-plain.svg and takeout plain from the devicon.json file.

inpour · 2024-01-16T11:21:03Z

Thank you for reviewing!

I deleted the aerospike-plain.svg and pushed changes.

Snailedlt

Looks good for the most part!
The icons are excellent, so just a few minor details in the devicon.json left

devicon.json

Snailedlt

Excellent work!
Thank you for a great PR! 💯

weh

Looking good 👍

inpour · 2024-01-22T10:40:27Z

@canaleal , What is the problem with requested changes?

canaleal

Great work. All is good.

inpour · 2024-02-05T08:32:59Z

Well, when will this PR be merged?

weh · 2024-02-07T11:15:28Z

Well, when will this PR be merged?

the main focus was currently on the Release https://github.com/devicons/devicon/releases/tag/v2.16.0
so i guess this will happen soon, and is just a matter of time.
From your side, this MR is OK and ready, it has the needed reviews, so nothing to do left 👍

inpour · 2024-02-07T11:40:30Z

Thanks @weh.

github-actions · 2024-02-17T17:23:38Z

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

github-actions · 2024-02-17T18:09:22Z

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

weh

LGTM 👍

Co-authored-by: Alex Canales <[email protected]>

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

github-actions · 2024-11-10T03:32:05Z

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

new icon: aerospike (original, original-wordmark)

canaleal reviewed Jan 15, 2024

View reviewed changes

canaleal requested changes Jan 15, 2024

View reviewed changes

devicon.json Outdated Show resolved Hide resolved

devicon.json Outdated Show resolved Hide resolved

inpour requested a review from canaleal January 15, 2024 08:27

canaleal requested changes Jan 16, 2024

View reviewed changes

inpour requested a review from canaleal January 16, 2024 11:21

Snailedlt changed the title ~~new icon: aerospike (original, original-wordmark, plain)~~ new icon: aerospike (original, original-wordmark) Jan 16, 2024

Snailedlt requested changes Jan 16, 2024

View reviewed changes

devicon.json Outdated Show resolved Hide resolved

devicon.json Outdated Show resolved Hide resolved

inpour requested a review from Snailedlt January 16, 2024 14:50

Snailedlt previously approved these changes Jan 16, 2024

View reviewed changes

Snailedlt requested review from a team, ConX, lunatic-fox and weh and removed request for a team January 16, 2024 14:55

Snailedlt added the feature:icon PR when a new icon is ready to be added to the collection label Jan 16, 2024

weh previously approved these changes Jan 18, 2024

View reviewed changes

canaleal previously approved these changes Jan 23, 2024

View reviewed changes

canaleal dismissed stale reviews from Snailedlt and themself via bf23f8d February 17, 2024 18:08

inpour dismissed weh’s stale review via bf23f8d May 25, 2024 03:18

canaleal approved these changes Sep 27, 2024

View reviewed changes

weh approved these changes Oct 2, 2024

View reviewed changes

inpour force-pushed the new-icon-aerospike branch from 54c9e33 to fef6839 Compare October 6, 2024 06:41

inpour and others added 8 commits October 8, 2024 14:21

new icon aerospike

63ec296

change color to '#c21417'

9e37780

Co-authored-by: Alex Canales <[email protected]>

update aliases

20b5bdd

Co-authored-by: Alex Canales <[email protected]>

update svg files

95bbae7

delete aerospike-plain.svg

4243809

update aliases

12ca969

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

update altnames

ffb28fb

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

Moved aerospike to correct position

a2baad7

inpour force-pushed the new-icon-aerospike branch from fef6839 to a2baad7 Compare October 8, 2024 10:51

Merge branch 'develop' into new-icon-aerospike

e275eae

canaleal merged commit d71dda3 into devicons:develop Nov 10, 2024
5 checks passed

GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024

Merge pull request devicons#2111 from ah-aliakbarpour/new-icon-aerospike

a64cb23

new icon: aerospike (original, original-wordmark)

new icon: aerospike (original, original-wordmark) #2111

new icon: aerospike (original, original-wordmark) #2111

Uh oh!

Conversation

inpour commented Jan 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Double check these details before you open a PR

Link to prove your SVG is correct and up-to-date.

Uh oh!

canaleal left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Using Aliases

Uh oh!

canaleal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

canaleal left a comment

Choose a reason for hiding this comment

Uh oh!

inpour commented Jan 16, 2024

Uh oh!

Snailedlt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Snailedlt left a comment

Choose a reason for hiding this comment

Uh oh!

weh left a comment

Choose a reason for hiding this comment

Uh oh!

inpour commented Jan 22, 2024

Uh oh!

canaleal left a comment

Choose a reason for hiding this comment

Uh oh!

inpour commented Feb 5, 2024

Uh oh!

weh commented Feb 7, 2024

Uh oh!

inpour commented Feb 7, 2024

Uh oh!

github-actions bot commented Feb 17, 2024

Uh oh!

github-actions bot commented Feb 17, 2024

Uh oh!

weh left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 10, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

inpour commented Jan 14, 2024 •

edited

Loading

canaleal left a comment •

edited

Loading