Add ppc64le support for base image #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

prabhuk25 wants to merge 7 commits into devfile:main from prabhuk25:ppc64le-support

+235 −106

prabhuk25 commented Nov 18, 2025

Enhanced the UBI9 image for ppc64le support and modified the UBI9 build workflow to support ppc64le arch with existing runners.

openshift-ci bot added the do-not-merge/work-in-progress label

openshift-ci bot commented Nov 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prabhuk25

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

prabhuk25 added 5 commits

November 20, 2025 01:23


          Enhance architecture support for tool installations

a0872bb

Refactor installation steps for various tools to support multiple architectures and improve error handling.

Signed-off-by: Prabhu K <Prabhu.K@ib,.com>


          Enhance UBI 9 build workflow for multi-arch support

07c6888

Updated the GitHub Actions workflow to support multi-architecture builds for UBI 9 base images, including amd64, arm64, and ppc64le. Adjusted the build and publish steps accordingly.

Signed-off-by: Prabhu K <Prabhu.K@ib,.com>


          Refactor UBI9 build workflow and update steps

ff3dbf4

Refactor UBI9 build workflow for improved clarity and functionality.

Signed-off-by: Prabhu K <Prabhu.K@ib,.com>


          Refactor GitHub Actions workflow for multi-architecture builds

aad96eb

Enhanced for ppc64le arch

Signed-off-by: Prabhu K <Prabhu.K@ib,.com>


          Refactor PR check workflow for multi-architecture builds

ad28338

Enhanced for ppc64le arch

Signed-off-by: Prabhu K <Prabhu.K@ib,.com>

prabhuk25 force-pushed the ppc64le-support branch from f9c9eea to ad28338 Compare

November 20, 2025 06:25

prabhuk25 marked this pull request as ready for review

November 20, 2025 06:27

prabhuk25 requested review from SDawley, dkwon17 and svor as code owners

November 20, 2025 06:27

openshift-ci bot removed the do-not-merge/work-in-progress label

dkwon17 reviewed

View reviewed changes

Collaborator

dkwon17 left a comment

Thank you for the PR, so far, I have a couple of comments

base/ubi9/Dockerfile

    
                      amd64) GH_ARCH="linux_amd64" ;; \

                      arm64) GH_ARCH="linux_arm64" ;; \

                      ppc64le) GH_ARCH="linux_ppc64le" ;; \

                      *) echo "Unsupported architecture: $TARGETARCH" && exit 0 ;; \

Collaborator

dkwon17 Nov 29, 2025

Could we follow this case pattern for the other RUN statements (ripgrep, bat, fd, kubedock) as well?

Author

prabhuk25 Dec 1, 2025

Updated as per the suggestion

.github/workflows/ubi9-build.yaml Outdated Show resolved Hide resolved

prabhuk25 and others added 2 commits

December 1, 2025 17:58


          Refactor architecture-specific installation logic

c2ec1c2


          Update .github/workflows/ubi9-build.yaml

04e1d01

Co-authored-by: David Kwon <[email protected]>

rohanKanojia reviewed

View reviewed changes

.github/workflows/ubi9-build.yaml

    
                    # Setup QEMU for cross-platform builds

                    - name: Set up QEMU

                      uses: docker/setup-qemu-action@v2

                    # Setup Docker Buildx with container driver

Member

rohanKanojia Dec 29, 2025

Suggested change

# Setup Docker Buildx with container driver

rohanKanojia reviewed

View reviewed changes

.github/workflows/ubi9-build.yaml

    
                      run: sudo rm -rf /usr/local/lib/android

                    - name: Cleanup docker images

                      run: docker system prune -af

                    # Setup QEMU for cross-platform builds

Member

rohanKanojia Dec 29, 2025 •

edited

Loading

I think these comments don't add much value. I suggest removing them

Suggested change

# Setup QEMU for cross-platform builds

rohanKanojia reviewed

View reviewed changes

.github/workflows/ubi9-build.yaml

    
                    # Setup QEMU for cross-platform builds

                    - name: Set up QEMU

                      uses: docker/setup-qemu-action@v2

                    # Setup Docker Buildx with container driver

Member

rohanKanojia Dec 29, 2025

Suggested change

# Setup Docker Buildx with container driver

rohanKanojia reviewed

View reviewed changes

.github/workflows/ubi9-build.yaml

    
                      run: sudo rm -rf /usr/local/lib/android

                    - name: Cleanup docker images

                      run: docker system prune -af

                    # Setup QEMU for cross-platform builds

Member

rohanKanojia Dec 29, 2025

Suggested change

# Setup QEMU for cross-platform builds

Member

rohanKanojia commented Dec 29, 2025

@prabhuk25 : Do you think these changes need to be ported for UBI10 too?

https://github.com/devfile/developer-images/blob/main/base/ubi10/Dockerfile

Member

rohanKanojia commented Dec 29, 2025

@prabhuk25 : It seems build is failing for ppc64le . Do you know if ubuntu-22.04 runner has ppc64le emulation enabled?

#9 [ 2/20] RUN mkdir -p /home/tooling/
#9 0.111 exec /bin/sh: exec format error
#9 ERROR: process "/bin/sh -c mkdir -p /home/tooling/" did not complete successfully: exit code: 255
------
 > [ 2/20] RUN mkdir -p /home/tooling/:
0.111 exec /bin/sh: exec format error
------
ERROR: failed to build: failed to solve: process "/bin/sh -c mkdir -p /home/tooling/" did not complete successfully: exit code: 255
Error: Process completed with exit code 1.

Author

prabhuk25 commented Dec 29, 2025

@rohanKanojia: No, the ubuntu-22.04 GitHub-hosted runner does not have ppc64le emulation enabled by default. So, I have used QEMU to enable explicitly.

Author

prabhuk25 commented Dec 29, 2025

@prabhuk25 : Do you think these changes need to be ported for UBI10 too?

https://github.com/devfile/developer-images/blob/main/base/ubi10/Dockerfile

Yeah, it is good to have it for UBI10 as well

rohanKanojia reviewed

View reviewed changes

.github/workflows/pr-check.yaml

    
                        else

                          echo arch="arm64" >> $GITHUB_ENV

                        fi

                      run: echo "arch=${{ matrix.arch }}" >> $GITHUB_ENV

Member

rohanKanojia Dec 29, 2025

I think we should also have QEMU setup in this workflow (like ubi9-build.yaml)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rohanKanojia rohanKanojia left review comments

dkwon17 dkwon17 left review comments

svor Awaiting requested review from svor svor is a code owner

SDawley Awaiting requested review from SDawley SDawley is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet