fix: continue_on_success_ratio without slice raise error#852
Draft
saltball wants to merge 1 commit intodeepmodeling:masterfrom
Draft
fix: continue_on_success_ratio without slice raise error#852saltball wants to merge 1 commit intodeepmodeling:masterfrom
saltball wants to merge 1 commit intodeepmodeling:masterfrom
Conversation
Collaborator
|
Can you provide an example? |
saltball
force-pushed
the
fix-step-slice-if-expression
branch
from
15305cb to
bbbc978
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some conditions, the slice expression do not worked for if_expression when combining and split the job groups. This PR tries to fix this.
The problem hardly effect the normal users especially the executor users. I'll check it further and provide details later.