2026PKUCourseHW5: Case: 4 - Implement file loading in root process#7186
Open
Silver-Moon-Over-Snow wants to merge 3 commits intodeepmodeling:developfrom
Open
2026PKUCourseHW5: Case: 4 - Implement file loading in root process#7186Silver-Moon-Over-Snow wants to merge 3 commits intodeepmodeling:developfrom
Silver-Moon-Over-Snow wants to merge 3 commits intodeepmodeling:developfrom
Conversation
Consider the previous contributions made by classmates, I'm only capable to make small difference without disrupting the entire program ---- like such a small "static".
…w_Small-Changes 2025PKUCourseHW5: Case: 1 - Change rank_seed_offset to static const
Added file loading logic for the root process with error handling. Especially, we include the check for "else" case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Added file loading logic for the root process with error handling. Especially, we include the check for "else" case. That's non-root processes: wait for root process to finish file loading and data broadcast.
To sum up, that's my third try on the program. (wrestled with case 1, 4, and 5) However, my commit on other branches may be entangled with this PR, and I'm sorry about that.
Reminder