Skip to content

2026PKUCourseHW5: fix- replace unsafe atoi/atof with function safe_ca…#7185

Closed
SunsetStand wants to merge 1 commit intodeepmodeling:developfrom
SunsetStand:fix/type-conversion-issue
Closed

2026PKUCourseHW5: fix- replace unsafe atoi/atof with function safe_ca…#7185
SunsetStand wants to merge 1 commit intodeepmodeling:developfrom
SunsetStand:fix/type-conversion-issue

Conversation

@SunsetStand
Copy link
Copy Markdown

…st using std::stoi/std::stod

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #...

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@mohanchen
Copy link
Copy Markdown
Collaborator

Nice try! Thanks for your contribution.

@mohanchen mohanchen closed this Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants