Refactor: Unify CUDA spherical harmonics (sph_harm) implementation (Useful information for using Ylm in both CPU and GPU coding) #6947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract common spherical harmonics computation into a shared header (sph_harm_gpu.cuh) and remove duplicate implementations from gint and rt modules. This improves code maintainability and ensures consistent behavior across all CUDA kernels. Co-Authored-By: Claude Opus 4.5 <[email protected]>
mohanchen
approved these changes
Feb 3, 2026
mohanchen
added
Refactor
mohanchen
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
source/source_base/kernels/cuda/sph_harm_gpu.cuh)ylmcoef.hfor spherical harmonics coefficients🤖 Generated with Claude Code