fix: re-enable and repair skipped deployment tests (#8)

[NakulSingh156]

Pull Request

Description

I noticed test_deploy.py contained several tests skipped with "temporarily disabled since code needs fixing". I have investigated and fixed the underlying issues to re-enable them.

Changes:

1. Updated correct_dataset JSON structure in test_empty_cvs to match the current API output (Artifact/Version split).
2. Fixed get_file_info call signature in test_distribution_cases (removed unused artifact_name argument).
3. Added logic to handle default 'none' compression and live checksum fetching during test generation loop.

Result: All 3 tests in test_deploy.py now pass.

Related Issues
Resolves #8

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• This change requires a documentation update
• Housekeeping

Checklist:

• My code follows the ruff code style of this project.
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (if applicable)
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
  • poetry run pytest - all tests passed
  • poetry run ruff check - no linting errors

Summary by CodeRabbit

• Tests

  • Updated test cases to validate changes in runtime behavior.
  • Refined expected data structure validations.
  • Adjusted conditional execution path handling in tests.

• Chores

  • Streamlined internal component interactions and function signatures.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

This change adjusts test cases in tests/test_deploy.py to match API updates. The get_file_info() function signature was simplified to accept a single dst_string parameter instead of both artifact_name and dst_string. Test expectations for JSON structure and function return values were updated accordingly.

Changes

Cohort / File(s)

Summary

Test adjustments tests/test_deploy.py

Updated test_distribution_cases to call get_file_info(dst_string) with single argument; added default "none" variant handling in expected dst_string; conditionally appends sha256sum and content length when checksum is skipped. Updated test_empty_cvs expected JSON structure to reflect Artifact/Dataset reorganization, including moving hasVersion/license fields and updating distribution metadata with byteSize and formatExtension. Removed name variable from return value unpacking.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: re-enabling and repairing skipped deployment tests, with reference to issue #8.
Description check	✅ Passed	The description covers all required sections: it explains the changes made, identifies related issues, specifies the type of change, and completes most checklist items with clear justifications.
Linked Issues check	✅ Passed	The PR successfully re-enables and fixes the failing tests in test_deploy.py by correcting API output structure, fixing function signatures, and handling default compression, directly addressing issue #8's objective.
Out of Scope Changes check	✅ Passed	All changes in the PR are scoped to fixing test_deploy.py tests and their underlying issues as required by #8; no unrelated modifications are present.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}