Skip to content

Conversation

@dmaresma
Copy link
Contributor

@dmaresma dmaresma commented Jun 11, 2025

Hi, I use snowflake as main EDW workspace, I notice some regression when simple-ddl-parser was replaced by sqlglot unfortunatly snowflake ddl import is a show stopper for me, in the migration of the catalog into datacontracts.
I take care to maintain sqlglot / sqlserver fonctionnality as is. the sql server test pass.

regression on tags, ddl comment/description, and data type

  • Tests pass
  • ruff format
  • README.md updated (if relevant)
  •  CHANGELOG.md entry added

@simonharrer
Copy link
Contributor

Can you elaborate on the error with sqlglot? We'd rather want to fix the issue there and not re-introduce the previously removed library.

@dmaresma
Copy link
Contributor Author

dmaresma commented Jun 13, 2025

I found the `AUTOINCREMENT START # INCREMENT [NOORDER|ORDER] do sqlglot fail, a PR is send to them (sqlglot team already) tobymao/sqlglot#5223,
Then I use ${} syntax as internal token for my DDL, sqlglot is not friendly, I substitute from the sql automaticaly (a kind a favor),
I fix the Table description et Column description in the mapping,
I fix the column tag catch too.
Thanks for your attention

@dmaresma
Copy link
Contributor Author

@simonharrer Can I ask for a review, the comment on snowflake are now well supported for snowflake, and simpleddl is removed.

@dmaresma
Copy link
Contributor Author

@simonharrer is it possible to merge this fix for snowflake sql ddl import for comment, tags ?

@dmaresma dmaresma requested a review from jochenchrist July 14, 2025 13:10
@dmaresma
Copy link
Contributor Author

I include a fix for the T-SQL money data type to decimal related to #751

@dmaresma
Copy link
Contributor Author

dmaresma commented Oct 1, 2025

@simonharrer please review this PR, it's 2 month old already and solve attributes and table comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants