-
Notifications
You must be signed in to change notification settings - Fork 189
Feat/snowflake ddl sql import solve #789 #790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat/snowflake ddl sql import solve #789 #790
Conversation
|
Can you elaborate on the error with sqlglot? We'd rather want to fix the issue there and not re-introduce the previously removed library. |
|
I found the `AUTOINCREMENT START # INCREMENT [NOORDER|ORDER] do sqlglot fail, a PR is send to them (sqlglot team already) tobymao/sqlglot#5223, |
…d).lint(enabled_linters=set()).has_passed()
|
@simonharrer Can I ask for a review, the comment on snowflake are now well supported for snowflake, and simpleddl is removed. |
…aresma/datacontract-cli into feat/snowflake_ddl_sql_import
|
@simonharrer is it possible to merge this fix for snowflake sql ddl import for comment, tags ? |
|
I include a fix for the T-SQL money data type to decimal related to #751 |
|
@simonharrer please review this PR, it's 2 month old already and solve attributes and table comment |
Hi, I use snowflake as main EDW workspace, I notice some regression when simple-ddl-parser was replaced by sqlglot unfortunatly snowflake ddl import is a show stopper for me, in the migration of the catalog into datacontracts.
I take care to maintain sqlglot / sqlserver fonctionnality as is. the sql server test pass.
regression on tags, ddl comment/description, and data type