Centralize host URL normalization to fix auth profile matching#4684
Draft
Centralize host URL normalization to fix auth profile matching#4684
Conversation
Replace four separate host normalization implementations with a single exported NormalizeHost() function in libs/databrickscfg/host.go. The key fix is adding https:// when no scheme is present, which was missing from the primary normalizeHost used for bundle auth profile matching. This caused "cannot resolve bundle auth configuration" errors when hosts were stored without the https:// prefix (e.g. via `databricks apps init`). Also normalize the host before saving profiles in `auth login` to prevent bare hostnames from being persisted to .databrickscfg.
Collaborator
|
Commit: aad8605
16 interesting tests: 7 KNOWN, 7 SKIP, 2 flaky
Top 20 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Replace four separate host normalization implementations with a single exported NormalizeHost() function in libs/databrickscfg/host.go. The key fix is adding https:// when no scheme is present, which was missing from the primary normalizeHost used for bundle auth profile matching. This caused "cannot resolve bundle auth configuration" errors when hosts were stored without the https:// prefix (e.g. via
databricks apps init).Also normalize the host before saving profiles in
auth loginto prevent bare hostnames from being persisted to .databrickscfg.Why
We got a feedback: