Add default project name and success message to default-scala template#4661
Open
lennartkats-db wants to merge 5 commits intomainfrom
Open
Add default project name and success message to default-scala template#4661lennartkats-db wants to merge 5 commits intomainfrom
lennartkats-db wants to merge 5 commits intomainfrom
Conversation
The default-scala template was missing a default value for `project_name` and a `success_message`, unlike all other built-in templates. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lennartkats-db
requested review from
andrewnester,
anton-107,
denik,
pietern,
shreyas-goenka and
simonfaltum
as code owners
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 3530c41
25 interesting tests: 8 FAIL, 7 KNOWN, 7 SKIP, 2 flaky, 1 BUG
Top 22 slowest tests (at least 2 minutes):
|
pietern
approved these changes
Mar 5, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
simonfaltum
reviewed
Mar 12, 2026
Member
simonfaltum
left a comment
simonfaltum
left a comment
There was a problem hiding this comment.
Review (automated, 2 agents)
Verdict: Approve | 0 Critical | 0 Major | 1 Gap(Nit) | 1 Nit | 1 Suggestion
Clean, small PR. Consistent with other templates.
[Gap (Nit)] Acceptance test never exercises the default project_name behavior
acceptance/bundle/templates/default-scala/input.json hard-codes project_name, so the new "default": "my_scala_project" is never tested. Consider adding a test case that omits project_name.
[Nit] Inconsistent default project name convention
Most templates use sql_project, dbt_project (no my_ prefix). This PR uses my_scala_project. Consider scala_project for consistency with siblings.
[Suggestion] Verify output.txt was regenerated
Confirm output was generated by make test-update-templates rather than hand-crafted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This adds makes the
project_nameand asuccess_messagefields consistent with other templates.