Skip to content

Fix Python 3.14 TypeError for Iterable checks using collections.abc.Iterable #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Omarabdalgwad wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Python 3.14 TypeError for Iterable checks using collections.abc.Iterable #676

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions datascience/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import functools
import math
import collections
from collections.abc import Iterable

# Change matplotlib formatting. TODO incorporate into a style?
plt.rcParams['patch.force_edgecolor'] = True
Expand Down Expand Up @@ -261,11 +262,11 @@ def objective(args):
else:
return result.x

def is_non_string_iterable(value):
def is_non_string_iterable(value: object)-> bool:
"""Returns a boolean value representing whether a value is iterable."""
if isinstance(value, str):
return False
if hasattr(value, '__iter__'):
if isinstance(value, Iterable):
return True
return False

Loading