Skip to content

DAOS-17416 control: Use C.malloc in daos C API calls (#17479)#17606

Open
kjacque wants to merge 1 commit intorelease/2.6from
kjacque/2.6/cgo-malloc
Open

DAOS-17416 control: Use C.malloc in daos C API calls (#17479)#17606
kjacque wants to merge 1 commit intorelease/2.6from
kjacque/2.6/cgo-malloc

Conversation

@kjacque
Copy link
Contributor

@kjacque kjacque commented Feb 26, 2026 •
edited
Loading

Passing Go-allocated C structs into the daos C API was causing enough false positives in valgrind to make the results unusable.

Features: control

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@kjacque
DAOS-17416 control: Use C.malloc in daos C API calls (#17479)
a2a2a53 
Passing Go-allocated C structs into the daos C API was causing
enough false positives in valgrind to make the results unusable.

Features: control

Signed-off-by: Kris Jacque <kris.jacque@hpe.com>
@kjacque kjacque self-assigned this Feb 26, 2026
@kjacque kjacque requested review from a team as code owners February 26, 2026 01:26
@kjacque kjacque added unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving. release-2.6.5 labels Feb 26, 2026
@github-actions
Copy link

github-actions bot commented Feb 26, 2026

Ticket title is 'saw an NLT valgrind error on a PR - invalid write of size 8 in dc_pool2hdl() / d_hhash_link_key()'
Status is 'Awaiting backport'
Labels: 'triaged'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-17416

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Feb 26, 2026
@kjacque
Copy link
Contributor Author

kjacque commented Feb 26, 2026

This ended up being a re-implementation rather than a cherry-pick, since the affected code in master had been significantly refactored.

@kjacque kjacque requested review from knard38 and mjmac February 27, 2026 22:58
knard38
knard38 approved these changes Mar 2, 2026
View reviewed changes
Copy link
Contributor

@knard38 knard38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tanabarr tanabarr tanabarr approved these changes

@knard38 knard38 knard38 approved these changes

@mjmac mjmac Awaiting requested review from mjmac

Assignees

@kjacque kjacque

Labels

priority Ticket has high priority (automatically managed) release-2.6.5 unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kjacque @tanabarr @knard38