Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I looked through the CUPS Implementation of IPP documentation and found a few comments:
https://opensource.apple.com/source/cups/cups-218/cups/doc/help/spec-ipp.html#PRINT_JOB
https://opensource.apple.com/source/cups/cups-218/cups/doc/help/spec-ipp.html#CUPS_ADD_MODIFY_PRINTER
So I added the following two lines to the end of the
encode_dictfunction:I've checked printing files and adding printers with a driver on my CUPS server - everything works as expected!
I checked printing files and adding printers with a driver on my CUPS server - everything works as expected!
Furthermore, I know that similar functionality was added in one of the recent PRs, but in addition to changing the
encode_dictfunction, I added another test case and several examples.And, of course, thanks for the project! Waiting for your reply.