Skip to content

Conversation

@cccsss01
Copy link

No description provided.

@netlify
Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit 4193c3f
🔍 Latest deploy log https://app.netlify.com/sites/crossplane/deploys/67a57c46ea399900089aa4b2
😎 Deploy Preview https://deploy-preview-853--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 68 (🔴 down 6 from production)
Accessibility: 90 (🔴 down 2 from production)
Best Practices: 83 (no change from production)
SEO: 100 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

cccsss01 and others added 2 commits January 12, 2025 23:47
metadata:
name: provider-kubernetes
EOF
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing closing code block? or maybe one too much?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite know, this is what got it to work

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The triple backtick to close the code block in markdown.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok, i'll get to it.

name: cluster-admin
apiGroup: rbac.authorization.k8s.io
EOF
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing close code block here too?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand

Comment on lines +38 to +49
```yaml
cat <<EOF | kubectl apply -f -
apiVersion: pkg.crossplane.io/v1beta1
kind: DeploymentRuntimeConfig
metadata:
name: provider-kubernetes
spec:
serviceAccountTemplate:
metadata:
name: provider-kubernetes
EOF
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 looks we are missing a story here. What's going on? should the section Create a ProviderConfig below be dropped?

Copy link
Author

@cccsss01 cccsss01 Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh, i'm not too sure but it was required to make it work. I pulled this from someone else but i'll take a look.

Co-authored-by: Philippe Scorsolini <[email protected]>
Copy link
Author

@cccsss01 cccsss01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you're asking for but this all works.

metadata:
name: provider-kubernetes
EOF
---
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite know, this is what got it to work

name: cluster-admin
apiGroup: rbac.authorization.k8s.io
EOF
---
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand

@haarchri
Copy link
Member

haarchri commented Feb 2, 2026

@cccsss01 first off, thank you for the effort and time you put into this PR.

Since this PR was opened, the documentation has gone through significant updates as part of the Crossplane 2.0 refresh. Because of that, this PR is unfortunately now out of date, and the existing conflicts / issues haven't been resolved.

To keep the docs aligned with the current structure and content, we are going to close this PR for now.

That said, we would absolutely love to review this again if you would like to rework the changes against the latest version of the documentation. If you do, please make sure the content fits within the appropriate sections of the Crossplane v2 docs structure - think an good are is in the guide section.

Thanks again for the contribution and the work you put into this 🙌

@haarchri haarchri closed this Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants