-
Notifications
You must be signed in to change notification settings - Fork 149
Adding kubernetes-provider quickstart #853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Cory Sherman <[email protected]>
Signed-off-by: Cory Sherman <[email protected]>
| metadata: | ||
| name: provider-kubernetes | ||
| EOF | ||
| --- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing closing code block? or maybe one too much?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite know, this is what got it to work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The triple backtick to close the code block in markdown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah ok, i'll get to it.
| name: cluster-admin | ||
| apiGroup: rbac.authorization.k8s.io | ||
| EOF | ||
| --- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing close code block here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand
| ```yaml | ||
| cat <<EOF | kubectl apply -f - | ||
| apiVersion: pkg.crossplane.io/v1beta1 | ||
| kind: DeploymentRuntimeConfig | ||
| metadata: | ||
| name: provider-kubernetes | ||
| spec: | ||
| serviceAccountTemplate: | ||
| metadata: | ||
| name: provider-kubernetes | ||
| EOF | ||
| --- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 looks we are missing a story here. What's going on? should the section Create a ProviderConfig below be dropped?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh, i'm not too sure but it was required to make it work. I pulled this from someone else but i'll take a look.
Co-authored-by: Philippe Scorsolini <[email protected]>
Co-authored-by: Philippe Scorsolini <[email protected]>
Co-authored-by: Philippe Scorsolini <[email protected]>
Co-authored-by: Philippe Scorsolini <[email protected]>
cccsss01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you're asking for but this all works.
| metadata: | ||
| name: provider-kubernetes | ||
| EOF | ||
| --- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite know, this is what got it to work
| name: cluster-admin | ||
| apiGroup: rbac.authorization.k8s.io | ||
| EOF | ||
| --- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand
Co-authored-by: Philippe Scorsolini <[email protected]>
|
@cccsss01 first off, thank you for the effort and time you put into this PR. Since this PR was opened, the documentation has gone through significant updates as part of the Crossplane 2.0 refresh. Because of that, this PR is unfortunately now out of date, and the existing conflicts / issues haven't been resolved. To keep the docs aligned with the current structure and content, we are going to close this PR for now. That said, we would absolutely love to review this again if you would like to rework the changes against the latest version of the documentation. If you do, please make sure the content fits within the appropriate sections of the Crossplane v2 docs structure - think an good are is in the guide section. Thanks again for the contribution and the work you put into this 🙌 |

No description provided.