Skip to content

Windows coverage template to use UTF-8#166

Merged
mvandeberg merged 1 commit intocppalliance:developfrom
mvandeberg:pr/fix-windows-coverage-format
Feb 23, 2026
Merged

Windows coverage template to use UTF-8#166
mvandeberg merged 1 commit intocppalliance:developfrom
mvandeberg:pr/fix-windows-coverage-format

Conversation

@mvandeberg
Copy link
Contributor

@mvandeberg mvandeberg commented Feb 23, 2026

Summary by CodeRabbit

  • Chores
    • Enhanced continuous integration workflow to automatically generate and report code coverage metrics for all pull requests, improving visibility into code quality changes. Strengthened deployment safety gates by restricting production deployments to explicitly triggered non-pull-request events exclusively, ensuring only intentional and approved changes are deployed to production environments.

@coderabbitai
Copy link

coderabbitai bot commented Feb 23, 2026

Warning

Rate limit exceeded

@mvandeberg has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 19 minutes and 41 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between cb11077 and d228a02.

📒 Files selected for processing (1)
  • .github/workflows/code-coverage.yml
📝 Walkthrough

Walkthrough

The pull request modifies the code-coverage workflow to accept pull_request triggers on master and develop branches, adds explicit PYTHONUTF8=1 environment variable configuration for gcovr report-generation steps across Linux and Windows, and refines the deployment gate to prevent deployment from pull request events.

Changes

Cohort / File(s) Summary
GitHub Actions Code Coverage Workflow
.github/workflows/code-coverage.yml
Added pull_request event trigger for master and develop branches; introduced PYTHONUTF8=1 environment variable in both Linux and Windows gcovr report-generation steps; updated deploy job condition to exclude pull request runs with !== 'pull_request' gate.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Poem

🐰 A workflow so wise, now hops into view,
Pull requests tracked with UTF-8 true,
Deploy gates click—no PRs slip through,
Coverage reports fresh, oh what a crew! 🎯

🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title focuses on Windows UTF-8 encoding, which is one aspect of the changes, but misses the main objective of adding PR triggers to the workflow and gating deployment. Consider a title that captures the primary change, such as 'Add PR triggers and deployment gating to coverage workflow' or 'Add UTF-8 encoding and PR support to coverage workflow'.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mvandeberg mvandeberg force-pushed the pr/fix-windows-coverage-format branch from cb11077 to d228a02 Compare February 23, 2026 22:55
@mvandeberg mvandeberg merged commit 1328796 into cppalliance:develop Feb 23, 2026
18 checks passed
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://166.corosio.prtest3.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-02-23 22:55:38 UTC

@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.26%. Comparing base (f0a7c8e) to head (d228a02).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #166      +/-   ##
===========================================
+ Coverage    82.21%   82.26%   +0.05%     
===========================================
  Files           70       70              
  Lines         5876     5876              
===========================================
+ Hits          4831     4834       +3     
+ Misses        1045     1042       -3     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0a7c8e...d228a02. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants