Conversation
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughA conditional compilation fence was added to the OpenSSL context constructor to skip the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
||
| if (!cd.ciphersuites.empty()) | ||
| { | ||
| #ifndef OPENSSL_IS_BORINGSSL |
There was a problem hiding this comment.
Corosio does not have build configurations (no macros). This would have to be in a separate translation unit.
There was a problem hiding this comment.
This works when corosio does find_package(OpenSSL) and gets BoringSSL instead.
The macro gets there through #include <openssl/ssl.h>
I tested with my package manager which does this, and it works.
There was a problem hiding this comment.
I get it, of course it works. What I'm saying is that we don't use conditional compilation to change the nature of the binary on a specific platform. Every Capy library has to be the same. There's no "#if SINGLE_THREADED_MUTEX" or that stuff.
|
An automated preview of the documentation is available at https://147.corosio.prtest3.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-02-17 19:42:15 UTC |
|
GCOVR code coverage report https://147.corosio.prtest3.cppalliance.org/gcovr/index.html Build time: 2026-02-17 19:50:44 UTC |
Summary by CodeRabbit