Allow ExternalPusher and ExternalQueryable to be overriden separately #7224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you check the DCO? https://cortexmetrics.io/docs/contributing/#developer-certificates-of-origin-dcos |
yeya24
approved these changes
Jan 21, 2026
Contributor
yeya24
left a comment
yeya24
left a comment
There was a problem hiding this comment.
Looks good to me. Let's fix DCO
Signed-off-by: Junhao Yu <yujunhao@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Currently, the codebase requires specifying both ExternalPusher and ExternalQueryable to be able to override any of the pusher or queryable. But ideally they should be separated, this PR allows users to be able to override any of them while not touching the other.
Which issue(s) this PR fixes:
It doesn't fix any existing issue(s).
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]