-
Notifications
You must be signed in to change notification settings - Fork 3.9k
fix: overzealous 'token' and 'credential' security regexps #9085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: overzealous 'token' and 'credential' security regexps #9085
Conversation
|
Keep this PR in a mergeable state → Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
1 similar comment
|
Keep this PR in a mergeable state → Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
RomneyDa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rossigee I agree with this change. I think you could also remove the credentials and tokens folder blockers. Looks like some tests will need to be updated since they are now failing
|
I've created a branch with the necessary test updates and IntelliJ pattern fixes: ChangesTest Updates (
|
Remove test expectation for credentials.json which no longer matches after removing credentials.* pattern. Add new tests to verify legitimate source files (tokens.py, credentials.go, etc.) are not blocked. Co-authored-by: nate <[email protected]>
Remove credentials.* and token.* patterns from IntelliJ security ignore list to match the TypeScript core changes. This ensures consistent behavior across both IDE extensions. Co-authored-by: nate <[email protected]>
19fece7 to
19f7a1a
Compare
Description
Removes
tokenandcredentialsfile globs for files that Continue should not access.This matches legitimate source files that we would want our AI agents to be able to read and manage, such as 'tokens.py', 'tokens.go', 'tokens.c' etc etc.
Example:
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
N/A
Tests
N/A
Summary by cubic
Relaxed security ignore patterns by removing token., credentials., and the bare token/credentials filenames from indexing. This prevents excluding legitimate source files (e.g., tokens.py) while still ignoring *.token and other clear secret files (e.g., *.secret, *.secrets, auth.json).
Written for commit 19f7a1a. Summary will update automatically on new commits.