feat(codegen): allow fire-and-forget delete hooks (clientMutationId default)#695
Open
pyramation wants to merge 11 commits intomainfrom
Open
feat(codegen): allow fire-and-forget delete hooks (clientMutationId default)#695pyramation wants to merge 11 commits intomainfrom
pyramation wants to merge 11 commits intomainfrom
Conversation
…copy patterns - Convert queries.ts, mutations.ts, custom-queries.ts, custom-mutations.ts from lines.push() string concatenation to Babel AST generation - Convert client.ts and selection.ts from string template literals to template-copy pattern - Add hooks-ast.ts shared helper library for Babel AST node construction - Add template files: hooks-client.ts, hooks-selection.ts - Add AGENTS.md with codegen rules (AST-only, no string concat, templates as files) - Update test snapshots for Babel formatting changes (whitespace/formatting only)
…-browser-compatible - Add hyphenateKeys, flattenDbFields, buildDbConfig, seedArgvFromConfig, buildGenerateOptions to shared.ts as generic reusable utilities - Replace manual cliOverrides/hasNonInteractiveArgs with prompt->camelize->generate flow - Remove deprecated --browser-compatible flag from CLI, config types, and generate - Simplify both CLI entry points (graphql/codegen/src/cli, packages/cli) - Update test mocks to match new shared utility imports
- Remove all defaultSelect constants and overload 2 (without fields) from all hook generators - Remove buildDefaultSelectExpr, buildSelectFallbackExpr, buildDefaultSelectLiteral, getDefaultSelectFieldName - Remove withoutFieldsSelectionType, withoutFieldsListSelectionType, NON_SELECT_TYPES_AST - Remove buildDefaultSelectExpression from ORM custom-ops-generator - Remove defaultSelect/defaultRef from ORM model-generator - Make selection with fields required in all hook and ORM method signatures - Update 25 snapshots to reflect removed overloads
…utationId default)
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces an optional-selection “fire-and-forget” path for table delete hooks only. When no selection is provided, delete hooks will default to selecting just
clientMutationId(a PostGraphile-standard field on CRUD payloads), rather than entity fields.What changed (scoped to delete hooks):
selection.fields(unchanged typed path){ clientMutationId: string }in the payloadselectionas optional and uses:select: args.select ?? { clientMutationId: true }Rationale:
clientMutationIdcommunicates that this path intentionally returns no entity data.{ id: true }). This remains removed project-wide.Files of interest:
Note: This PR is based off the latest remove-default-selects branch. It will include its already-reviewed diffs (workflows path ignores, makage bump, etc.) when merged into main.
Review & Testing Checklist for Human (3–5 items)
selection.fieldsand returns typed entity payload{ clientMutationId: string }select: args.select ?? { clientMutationId: true }Recommended manual test plan:
pnpm buildpnpm test(should be all green; 3 snapshots updated relative to previous behavior)mutations/useDelete*Mutation.tsoutputs for:selectionin the implementation signature{ clientMutationId: true }Notes
clientMutationId.