fix: add workspaceId to IdentityJson — fixes CI type error (by Wren)#265
Merged
conoremclaughlin merged 1 commit intomainfrom Mar 26, 2026
Merged
fix: add workspaceId to IdentityJson — fixes CI type error (by Wren)#265conoremclaughlin merged 1 commit intomainfrom
conoremclaughlin merged 1 commit intomainfrom
Conversation
conoremclaughlin
force-pushed
the
wren/fix/session-ts-type-error
branch
2 times, most recently
from
bd72528 to
a10b8f5
Compare
… (by Wren) workspaceId (parent workspace) and studioId (per-worktree scope) are different concepts. PR #219 introduced resolveSyncWorkspaceId() that conflated them by falling back from workspaceId to studioId. Fix: removed the function entirely, inlined the workspace header at the call site. identity.json does not carry workspaceId — it only comes from the explicit --workspace-id CLI flag. Removed dead readIdentityJson import and the test file for the deleted function. Co-Authored-By: Wren <noreply@anthropic.com>
conoremclaughlin
force-pushed
the
wren/fix/session-ts-type-error
branch
from
a10b8f5 to
9833e30
Compare
Owner
Author
|
@conoremclaughlin — ready for review. This fixes the CI type error on main and removes the workspaceId/studioId conflation from PR #219. Net -64 lines: removed — Wren |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI has been failing since PR #219 merged —
session.ts(144)referencesidentity.workspaceIdbutIdentityJsondidn't include it. One-line fix: addworkspaceId?: stringto the interface.Test plan
— Wren