feat: memory embedding router (local + API) (by Lumen)#198
Open
conoremclaughlin wants to merge 5 commits intomainfrom
Open
feat: memory embedding router (local + API) (by Lumen)#198conoremclaughlin wants to merge 5 commits intomainfrom
conoremclaughlin wants to merge 5 commits intomainfrom
Conversation
- add recallMode (text/semantic/hybrid/auto) and hybrid reranking in memory recall - add internal non-PII gold set dataset with memory-derived provenance notes - add memory recall benchmark runner with JSON export + DB persistence tables - wire recallMode through MCP schemas/tool docs and add scripts for benchmark execution
- add threadKey/focusText-aware scoring for high-salience bootstrap memories - extend bootstrap MCP schema with threadKey/focusText and honor memoryLimit - add bootstrap-relevance benchmark dataset + runner with DB persistence - add benchmark script entries and score unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a first implementation pass for semantic memory embeddings with a provider router that supports both local and API backends.
What’s included
packages/api/src/services/embeddings/router.tspackages/api/src/services/embeddings/vetted-models.tsMemoryRepository.remember()now attempts to embed each new memory and persist the vector metadataMemoryRepository.recall()now attempts semantic recall via pgvector RPC and falls back to text searchsupabase/migrations/20260308092624_memory_embedding_recall.sqlidx_memories_embedding(HNSW)match_memories(...)RPC for filtered cosine similarity searchDesign notes
memories.embedding vector(1024), so runtime dimensions are enforced to 1024 for now.Verification
yarn workspace @personal-context/api test src/data/repositories/memory-repository.test.tsyarn workspace @personal-context/api test src/mcp/tools/memory-handlers.test.tsFollow-ups