Open
Conversation
Move the `instanceof SkPublicKey` check before the `isEd25519Key()` check in AuthenticationManager.authenticatePublicKey(). SK Ed25519 keys (sk-ssh-ed25519@openssh.com) match isEd25519Key() because their algorithm is "Ed25519", causing them to enter the generic Ed25519 path which tries DER encoding and fails with InvalidKeySpecException. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add tests that use realistic algorithm names ("Ed25519" and "EC")
matching what real SkEd25519PublicKey and SkEcdsaPublicKey return.
These reproduce the bug where isEd25519Key() matched SK Ed25519 keys
before the instanceof SkPublicKey check, causing DER encoding failure.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I should write a PR based on connectbot/connectbot#1931, let me know.