Remove resource and include directories from kernel json#115
Remove resource and include directories from kernel json#115mcbarton wants to merge 1 commit intocompiler-research:mainfrom
Conversation
|
@anutosh491 @vgvassilev This PR is ready for review. |
Unfortunately that works on some platforms depending if we have installed compiler and we can find the compiler... The resource-dir is particularly tricky to find and in CppInterOp we need to figure out how to make it part of the library. Only then we can drop it and be confident that we are not shooting our feet... |
I'll convert this PR to a draft for now then, until that time comes where we are confident we can drop it. |
When creating the interpreter we already detect and add the arguments for the resource and include directories using CppInterOp here
https://github.com/mcbarton/xeus-cpp/blob/b58b15b83b27fe2e73c00c469346eea65301464d/src/xinterpreter.cpp#L37C1-L56C2 . This makes their addition in the kernel json file redundant.