fix(cli): move sys.excepthook override to correct line, fix no argv test #1791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bearomorphism
requested review from
Lee-W,
noirbizarre and
woile
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1791 +/- ##
=======================================
Coverage 97.95% 97.95%
=======================================
Files 60 60
Lines 2646 2646
=======================================
Hits 2592 2592
Misses 54 54 ☔ View full report in Codecov by Sentry. |
Lee-W
reviewed
Jan 13, 2026
Collaborator
Author
|
Oh I see, will take a look |
bearomorphism
force-pushed
the
fix-raise-exception-issue
branch
from
0794acd to
4e29eb2
Compare
bearomorphism
changed the title
bearomorphism
force-pushed
the
fix-raise-exception-issue
branch
from
4e29eb2 to
70edfe0
Compare
bearomorphism
changed the title
bearomorphism
commented
Jan 14, 2026
Comment on lines
-24
to
-25
| out, _ = capsys.readouterr() | ||
| assert out.startswith("usage") |
Collaborator
Author
There was a problem hiding this comment.
These lines are unreachable...
bearomorphism
force-pushed
the
fix-raise-exception-issue
branch
2 times, most recently
from
53b0f25 to
8718994
Compare
… parameter, fix no argv test
bearomorphism
force-pushed
the
fix-raise-exception-issue
branch
from
8718994 to
5d6f91a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1789