Fix deprecated precommit#1569
Merged
Lee-W merged 2 commits intocommitizen-tools:v4-9-0-testfrom Aug 17, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4-9-0-test #1569 +/- ##
==============================================
Coverage ? 97.98%
==============================================
Files ? 58
Lines ? 2680
Branches ? 0
==============================================
Hits ? 2626
Misses ? 54
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Lee-W
approved these changes
Aug 7, 2025
721e7ea to
9f063cd
Compare
Original "push" stage has been deprecated since pre-commit v3.2.0. See pre-commit/pre-commit#2732 and pre-commit/pre-commit#2808 for detailed information.
2841bcc to
a893655
Compare
Contributor
Author
|
Nice! I guess #1560 can be closed |
Member
|
Thanks for the reminder. just closed it. I plan to get it released next week! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cz initmodifies.pre-commit-config.yamlin a deprecated way. This PR fixes that, however, pre-commit must be upgraded to v3.2.0 onwards.Currently, commitizen is writing something like this to
.pre-commit-config.yaml:However, pre-commit will complaint that it's deprecated like mentioned in #1560 .
The upstream modification was proposed in pre-commit/pre-commit#2732, and fixed in pre-commit/pre-commit#2808
That means, "pre-push" starts to be usable in v3.2.0, while "push" starts to be deprecated.
This changed has already been stated in https://github.com/commitizen-tools/commitizen/blob/master/docs/README.md?plain=1#L209
Consequently, these modifications were made:
Checklist
Code Changes
poetry alllocally to ensure this change passes linter check and testsDocumentation Changes
poetry doclocally to ensure the documentation pages renders correctlyExpected Behavior
See commitizen generates config like this:
Steps to Test This Pull Request
cz initAdditional Context
Close #1560