Improve hooks type annotation and fix missing link#1345
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1345 +/- ##
==========================================
+ Coverage 97.33% 97.58% +0.25%
==========================================
Files 42 55 +13
Lines 2104 2614 +510
==========================================
+ Hits 2048 2551 +503
- Misses 56 63 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
noirbizarre
approved these changes
Feb 7, 2025
Member
noirbizarre
left a comment
There was a problem hiding this comment.
👍🏼
Note for later:
- we should also provide them as pre-commit hook
- maybe we should have a
cz hook installor something like that to avoid the manual fetch with curl
Member
Author
Yep, I was thinking about that as well (but not yet have time 🥲). added an issue #1355 to track this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
Everything should still be the same
Steps to Test This Pull Request
None
Additional context