Conversation
🦋 Changeset detectedLatest commit: c5439c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fix(actionsMapFieldDefinitions): update parameter types to accept arrays for previous and next field definitions
islam3zzat
force-pushed
the
if/add-product-tailorings-actions
branch
from
b0017ae to
0ecadf8
Compare
…ding tests - Added product tailoring functionality in `product-tailoring.ts` to handle various action groups including base, meta, images, assets, attributes, and variants. - Created a comprehensive test suite in `product-tailoring-sync.spec.ts` to validate the behavior of the product tailoring actions, ensuring immutability and correctness of actions generated for various scenarios. - Included edge case handling and support for staged actions based on publish and staged flags. feat(array-actions-utils): add utility functions for action type checks
islam3zzat
force-pushed
the
if/add-product-tailorings-actions
branch
from
0ecadf8 to
19d173b
Compare
| * HELPER FUNCTIONS | ||
| */ | ||
|
|
||
| function _buildAttributeValue( |
There was a problem hiding this comment.
There is some duplicate code between product tailoring actions and product actions.
I opted for duplicating most of the code related to variant and attribute actions instead of extracting it into a common module because even though the actions seam identical, but the underlying type is different
For product tailoring: ProductTailoringAttribute and
productvarianttailoringdraft
| key, | ||
| oldDelivery.parcels, | ||
| newDelivery.parcels | ||
| ) as unknown as { oldObj: Parcel }; |
There was a problem hiding this comment.
after fixing extractMatchingPairs's type, we won't need to case the returned type.
|
@islam3zzat the pipeline is failing |
This seams to be unrelated error, maybe uncleaned resources. All PRs fail this step Is this a known issue @ajimae ? |
markus-azer
left a comment
markus-azer
left a comment
There was a problem hiding this comment.
LGTM 💯 , the code is so much for my poor eye 😁 but good testing coverage
3 participants
In this PR we: