🤖 ci: retry macOS builds to handle transient Apple timestamp failures#2783
Merged
ibetitsmike merged 2 commits intomainfrom Mar 5, 2026
Merged
🤖 ci: retry macOS builds to handle transient Apple timestamp failures#2783ibetitsmike merged 2 commits intomainfrom
ibetitsmike merged 2 commits intomainfrom
Conversation
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a reusable retry script (
scripts/retry.sh) and wires it into macOS code signing steps so transient Apple timestamp server outages don't fail the entire build.Background
The nightly macOS build (run 22660852909) failed at the "Package and publish for macOS" step with
The timestamp service is not available. This is Apple'scodesign --timestampserver going down briefly — a known intermittent issue. All other platforms succeeded.electron-builder has no built-in retry for codesign operations, so the fix is at the CI layer.
Implementation
New
scripts/retry.sh— a generic retry wrapper with no external dependencies:::group::/::endgroup::markers for clean log folding per attempt::error::annotation on final failure./scripts/retry.sh 3 30 make dist-mac...Retrying the full make target is safe because vite caching makes the
builddep near-instant on re-run, electron-builder overwrites itsrelease/output, and the subsequentgh release upload --clobberhandles upload conflicts.Generated with
mux• Model:anthropic:claude-opus-4-6• Thinking:xhigh• Cost:$2.68