-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: Add support for HTTP status in ResponseCache
#9855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi there, sk757a! 👋 Thank you for sending this PR! We expect the following in all Pull Requests (PRs).
Important We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works. If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md Sincerely, the mergeable bot 🤖 |
|
Nice addition. I'm not sure whether this should be classified as a bug or a feature, but I'm fine treating it as a feature. Please add a changelog entry here: https://github.com/codeigniter4/CodeIgniter4/blob/4.7/user_guide_src/source/changelogs/v4.7.0.rst#libraries |
michalsn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thank you!
ResponseCache
|
Thank you @sk757a |
Glad to help. I hope this is just the beginning. |
Description
Implementation of storing and returning HTTP status for a cached response.
Currently, ResponseCache always returns 200 OK, regardless of the controller's response.
Checklist: