This repository was archived by the owner on Jul 16, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 56
fix: update pyproject to install rust for py13 #647
Closed
Closed
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
8e288a2
fix: update pyproject to install rust for py13
thomasrockhu-codecov 1bcf1da
fix: run pypi
thomasrockhu-codecov 09e1ab6
fix: make it default
thomasrockhu-codecov 19eae0b
fix: source the shell
thomasrockhu-codecov c166819
fix: separate out the commands
thomasrockhu-codecov a867556
fix: install rust
thomasrockhu-codecov cab5b26
fix: try more things
thomasrockhu-codecov 6c3bad0
fix: exec bash
thomasrockhu-codecov 781d3a6
fix: update things for windows
thomasrockhu-codecov 715159c
Merge branch 'main' into th/enable-py13-pypi-builds
thomasrockhu-codecov 88fbb93
fix: comment out
thomasrockhu-codecov 6d00972
fix: use rust things
thomasrockhu-codecov a7e2148
fix: things
thomasrockhu-codecov 5c78bce
fix: do it for all
thomasrockhu-codecov 0d1775d
fix: try updating path
thomasrockhu-codecov b43b3a0
fix: update on test-results-parser
thomasrockhu-codecov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,7 @@ | |
| name: Build for PyPi | ||
|
|
||
| on: | ||
| pull_request: | ||
| workflow_call: | ||
| inputs: | ||
| publish: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend calling this job from
ci.ymlinstead and running builds for PRs unconditionally. Of course, you'll probably want to skip a portion of wheels in PRs (as an optimization), but could still build x86_64 — you're double-building them viapip install -e .anyway. But by integrating this instead, you could get closer to releasing exactly what you test.