Fix nullable annotation for types with generics#92
Open
paramamue wants to merge 1 commit intocodecentric:masterfrom
Open
Fix nullable annotation for types with generics#92paramamue wants to merge 1 commit intocodecentric:masterfrom
paramamue wants to merge 1 commit intocodecentric:masterfrom
Conversation
paramamue
force-pushed
the
defaultvalue-null
branch
from
6b31e62 to
d8ac0ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a correction for my PR #85 a few months ago.
The current code generates invalid syntax for a null parameter with generic arguments because it searches for the first whitespace.
Func<int,? int> func = nullI switched to a CSharpSyntaxRewriter, which hopefully properly handles all other cases that might exist.