refactor: remove noise files from test coverage #1214

poltorak · 2026-01-12T14:06:58Z

Covers part 3 of #1168

Added more files to be excluded in test coverage report

nx-cloud · 2026-01-12T14:08:26Z

View your CI Pipeline Execution ↗ for commit bd747d0

Command	Status	Duration	Result
`nx run ci:code-pushup -- merge-diffs --files=/h...`	✅ Succeeded	5s	View ↗
`nx run-many --targets=code-pushup --parallel=fa...`	✅ Succeeded	1m 25s	View ↗
`nx run-many --targets=code-pushup --parallel=fa...`	✅ Succeeded	12m 32s	View ↗

☁️ Nx Cloud last updated this comment at 2026-01-13 17:00:21 UTC

pkg-pr-new · 2026-01-12T14:08:37Z

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1214

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1214

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1214

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1214

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1214

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1214

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1214

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1214

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1214

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1214

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1214

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1214

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1214

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1214

commit: bd747d0

github-actions · 2026-01-12T14:15:10Z

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit bf38c72 with previous commit 7d3681c.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Performance	🔴 37	🔴 34
Code coverage	🟢 91	🟢 92
Bug prevention	🟡 75	🟡 75
Axe Accessibility	🟡 88	🟡 88
Documentation	🔴 34	🔴 34
Code style	🟢 99	🟢 99	–
Security	🟡 51	🟡 51	–
Updates	🟡 78	🟡 78	–
Type Safety	🟡 67	🟡 67	–
Miscellaneous	🟡 67	🟡 67	–
Accessibility	🟢 92	🟢 92	–
Best Practices	🟢 100	🟢 100	–
SEO	🟢 92	🟢 92	–

👍 1 group improved, 👎 2 groups regressed, 👍 3 audits improved, 👎 5 audits regressed, 12 audits changed without impacting score

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score
Lighthouse	Performance	🔴 37	🔴 34
Code coverage	Code coverage metrics	🟢 91	🟢 92
JSDocs coverage	Documentation coverage	🔴 34	🔴 34

31 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
Lighthouse	Initial server response time was short	🟩 Root document took 400 ms	🟥 Root document took 660 ms
Lighthouse	Speed Index	🟥 5.9 s	🟥 7.5 s
Code coverage	Line coverage	🟨 86.2 %	🟩 92.5 %
Lighthouse	First Contentful Paint	🟥 3.0 s	🟥 3.1 s
Lighthouse	Time to Interactive	🟥 13.0 s	🟥 14.3 s
Lighthouse	Total Blocking Time	🟥 1,990 ms	🟥 2,440 ms
Code coverage	Branch coverage	🟨 87.3 %	🟨 89 %
Code coverage	Function coverage	🟩 93.4 %	🟩 94.1 %
Lighthouse	Minimizes main-thread work	🟥 8.9 s	🟥 11.1 s
Lighthouse	Avoids enormous network payloads	🟩 Total size was 2,113 KiB	🟩 Total size was 2,111 KiB
Lighthouse	Metrics	🟩 100%	🟩 100%
Lighthouse	JavaScript execution time	🟥 4.4 s	🟥 5.4 s
Lighthouse	Server Backend Latencies	🟩 1,050 ms	🟩 230 ms
Lighthouse	Uses efficient cache policy on static assets	🟨 31 resources found	🟨 31 resources found
Lighthouse	Largest Contentful Paint	🟥 11.4 s	🟥 12.0 s
Lighthouse	Max Potential First Input Delay	🟥 1,040 ms	🟥 1,460 ms
Lighthouse	Reduce unused CSS	🟥 Potential savings of 95 KiB	🟥 Potential savings of 95 KiB
Lighthouse	Reduce unused JavaScript	🟥 Potential savings of 200 KiB	🟥 Potential savings of 223 KiB
Lighthouse	Network Round Trip Times	🟩 0 ms	🟩 20 ms
JS packages	Outdated npm dev dependencies.	🟨 55 outdated package versions (29 major, 19 minor, 7 patch)	🟨 56 outdated package versions (29 major, 19 minor, 8 patch)

659 other audits are unchanged.

github-actions · 2026-01-12T14:22:47Z

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit bf38c72 with previous commit 7d3681c.

💼 Project `create-cli`

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	🟢 90	🟢 96

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	Code coverage metrics	🟢 90	🟢 96

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value	🔄 Value change
Code coverage	Line coverage	🟨 82.5 %	🟩 97 %
Code coverage	Branch coverage	🟨 73.7 %	🟨 87.5 %

442 other audits are unchanged.

💼 Project `nx-plugin`

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	🟡 89	🟢 91

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	Code coverage metrics	🟡 89	🟢 91

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value	🔄 Value change
Code coverage	Line coverage	🟨 84.8 %	🟩 93.2 %
Code coverage	Branch coverage	🟨 76.3 %	🟨 80.8 %

446 other audits are unchanged.

💼 Project `plugin-jsdocs`

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	🟢 95	🟢 97

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	Code coverage metrics	🟢 95	🟢 97

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value	🔄 Value change
Code coverage	Line coverage	🟩 90.5 %	🟩 96 %
Code coverage	Branch coverage	🟨 87.9 %	🟩 92.5 %

442 other audits are unchanged.

💼 Project `cli`

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	🟢 92	🟢 94

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	Code coverage metrics	🟢 92	🟢 94

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value	🔄 Value change
Code coverage	Line coverage	🟨 88.5 %	🟩 94.5 %
Code coverage	Branch coverage	🟨 84.2 %	🟨 86.9 %

442 other audits are unchanged.

💼 Project `plugin-axe`

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	🟢 93	🟢 94

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	Code coverage metrics	🟢 93	🟢 94

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value	🔄 Value change
Code coverage	Branch coverage	🟨 86.3 %	🟩 90.1 %
Code coverage	Line coverage	🟨 69.7 %	🟨 72.2 %

441 other audits are unchanged.

💼 Project `plugin-typescript`

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	🟡 86	🟡 87

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	Code coverage metrics	🟡 86	🟡 87

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value	🔄 Value change
Code coverage	Line coverage	🟩 90.7 %	🟩 95.5 %
Code coverage	Branch coverage	🟨 77.7 %	🟨 80.2 %

442 other audits are unchanged.

💼 Project `plugin-lighthouse`

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	🟢 99	🟢 99

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	Code coverage metrics	🟢 99	🟢 99

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value	🔄 Value change
Code coverage	Line coverage	🟩 97.2 %	🟩 99.8 %
Code coverage	Branch coverage	🟩 96.2 %	🟩 98.8 %

442 other audits are unchanged.

💼 Project `models`

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	🟢 93	🟢 94

3 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	Code coverage metrics	🟢 93	🟢 94

11 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value	🔄 Value change
Code coverage	Branch coverage	🟩 91.5 %	🟩 94.2 %
Code coverage	Line coverage	🟩 97.2 %	🟩 99.4 %

435 other audits are unchanged.

💼 Project `ci`

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	🟢 92	🟢 92

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved, 👎 1 audit regressed

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	Code coverage metrics	🟢 92	🟢 92

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
Code coverage	Line coverage	🟨 89.7 %	🟩 94.8 %
Code coverage	Branch coverage	🟨 82.4 %	🟨 83.6 %
Code coverage	Function coverage	🟩 96.6 %	🟩 96.6 %

442 other audits are unchanged.

💼 Project `core`

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	🟡 90	🟢 90

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	Code coverage metrics	🟡 90	🟢 90

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value	🔄 Value change
Code coverage	Line coverage	🟩 91.2 %	🟩 94.8 %
Code coverage	Branch coverage	🟨 81.7 %	🟨 83.2 %

442 other audits are unchanged.

💼 Project `plugin-coverage`

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	🟡 89	🟢 90

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	Code coverage metrics	🟡 89	🟢 90

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value	🔄 Value change
Code coverage	Line coverage	🟨 85.7 %	🟨 88 %
Code coverage	Branch coverage	🟨 88.1 %	🟨 89.6 %

442 other audits are unchanged.

💼 Project `plugin-eslint`

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	🟢 94	🟢 94

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved, 👎 1 audit regressed

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	Code coverage metrics	🟢 94	🟢 94

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
Code coverage	Line coverage	🟩 92.6 %	🟩 95 %
Code coverage	Branch coverage	🟨 85.2 %	🟨 86.5 %
Code coverage	Function coverage	🟩 98.2 %	🟩 98.2 %

441 other audits are unchanged.

💼 Project `plugin-js-packages`

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	🟡 85	🟡 86

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	Code coverage metrics	🟡 85	🟡 86

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value	🔄 Value change
Code coverage	Branch coverage	🟩 93.3 %	🟩 95 %
Code coverage	Line coverage	🟨 85 %	🟨 85.8 %

442 other audits are unchanged.

💼 Project `utils`

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	🟢 94	🟢 95
Documentation	🔴 36	🔴 36

4 other categories are unchanged.

👍 2 groups improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	Code coverage metrics	🟢 94	🟢 95
JSDocs coverage	Documentation coverage	🔴 36	🔴 36

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value	🔄 Value change
Code coverage	Line coverage	🟩 93.8 %	🟩 97.4 %
Code coverage	Branch coverage	🟩 91.8 %	🟩 92.1 %

442 other audits are unchanged.

BioPhoton

Added suggestio for type handling and including the tests folder.

BioPhoton · 2026-01-12T16:00:23Z

testing/test-setup-config/src/lib/vitest-config-factory.ts

+    'mocks/**',
+    'perf/**',


Suggested change

'mocks/**',

'perf/**',

'mocks/**',

'tests/**',

'perf/**',

As our e2e tests all are placed in tests folders.

BioPhoton · 2026-01-12T16:02:54Z

testing/test-setup-config/src/lib/vitest-config-factory.ts

+    '**/models.ts',
+    '**/*.model.ts',
+    '**/types.ts',
+    '**/*.types.ts',


We should have a naming convention like we do have with *.mock.ts in tests.
ATM in our. repo there are *.types.ts and *.type.ts and types.ts.
We could agree on having only *.type.ts and types.ts and standardise the repo.

I renamed packages/utils/src/lib/sink-source.types.ts -> packages/utils/src/lib/sink-source.type.ts because it was the only file with types suffix, now things are more unified

BioPhoton · 2026-01-12T21:36:58Z

Another idea... we could run-many unit-test and int test and ask AI to analyse for noise files. If it works the prompt could be attached to the PR description.

poltorak · 2026-01-13T11:39:38Z

Another idea... we could run-many unit-test and int test and ask AI to analyse for noise files. If it works the prompt could be attached to the PR description.

Not sure you meant by attaching prompt to description, however I ran AI against the coverage report, it suggested (mistakenly) to add some more files which actually contained methods. The only worth advice from it was to also add constants.ts, *.mock and fixtures/* files which I added

refactor: remove noise files from test coverage

fc0abc0

poltorak requested a review from BioPhoton January 12, 2026 14:06

poltorak self-assigned this Jan 12, 2026

github-actions bot added the 🔬 testing writing tests label Jan 12, 2026

BioPhoton reviewed Jan 12, 2026

View reviewed changes

refactor: improve excluded coverage files list

bd747d0

github-actions bot added the 🧩 utils label Jan 13, 2026

refactor: remove noise files from test coverage #1214

Are you sure you want to change the base?

refactor: remove noise files from test coverage #1214

Conversation

poltorak commented Jan 12, 2026

Uh oh!

nx-cloud bot commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code PushUp

🏷️ Categories

🗃️ Groups

🛡️ Audits

Uh oh!

github-actions bot commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code PushUp

💼 Project create-cli

🗃️ Groups

🛡️ Audits

💼 Project nx-plugin

🗃️ Groups

🛡️ Audits

💼 Project plugin-jsdocs

🗃️ Groups

🛡️ Audits

💼 Project cli

🗃️ Groups

🛡️ Audits

💼 Project plugin-axe

🗃️ Groups

🛡️ Audits

💼 Project plugin-typescript

🗃️ Groups

🛡️ Audits

💼 Project plugin-lighthouse

🗃️ Groups

🛡️ Audits

💼 Project models

🗃️ Groups

🛡️ Audits

💼 Project ci

🗃️ Groups

🛡️ Audits

💼 Project core

🗃️ Groups

🛡️ Audits

💼 Project plugin-coverage

🗃️ Groups

🛡️ Audits

💼 Project plugin-eslint

🗃️ Groups

🛡️ Audits

💼 Project plugin-js-packages

🗃️ Groups

🛡️ Audits

💼 Project utils

🗃️ Groups

🛡️ Audits

Uh oh!

BioPhoton left a comment

Choose a reason for hiding this comment

Uh oh!

BioPhoton Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

BioPhoton Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

poltorak Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

BioPhoton commented Jan 12, 2026

Uh oh!

poltorak commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

nx-cloud bot commented Jan 12, 2026 •

edited

Loading

pkg-pr-new bot commented Jan 12, 2026 •

edited

Loading

github-actions bot commented Jan 12, 2026 •

edited

Loading

github-actions bot commented Jan 12, 2026 •

edited

Loading

💼 Project `create-cli`

💼 Project `nx-plugin`

💼 Project `plugin-jsdocs`

💼 Project `cli`

💼 Project `plugin-axe`

💼 Project `plugin-typescript`

💼 Project `plugin-lighthouse`

💼 Project `models`

💼 Project `ci`

💼 Project `core`

💼 Project `plugin-coverage`

💼 Project `plugin-eslint`

💼 Project `plugin-js-packages`

💼 Project `utils`

poltorak commented Jan 13, 2026 •

edited

Loading