Skip to content

Conversation

@fwiesel
Copy link
Contributor

@fwiesel fwiesel commented Jan 28, 2026

It doesn't make sense to poll openstack for the hypervisors, when we are still evicting, so wait for that.

We have to match the condition to trigger the eviction and waiting on the eviction.

@fwiesel fwiesel requested a review from notandy January 28, 2026 09:00
It doesn't make sense to poll openstack for the hypervisors, when
we are still evicting, so wait for that.

We have to match the condition to trigger the eviction and waiting on
the eviction.
@github-actions
Copy link

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller 55.44% (-0.07%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/decomission_controller.go 53.73% (-0.96%) 67 (+3) 36 (+1) 31 (+2) 👎
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/hypervisor_maintenance_controller.go 71.60% (ø) 81 58 23

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/decomission_controller_test.go

@fwiesel fwiesel merged commit 6c733e0 into main Jan 28, 2026
6 checks passed
@fwiesel fwiesel deleted the decomission-when-evicted branch January 28, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants