Skip to content

Add kernel parameter reporting to hypervisor status#55

Merged
anokfireball merged 1 commit intomainfrom
feature/report-kernel-parameters
Feb 23, 2026
Merged

Add kernel parameter reporting to hypervisor status#55
anokfireball merged 1 commit intomainfrom
feature/report-kernel-parameters

Conversation

@anokfireball
Copy link
Contributor

This enables the operator to report kernel boot parameters in the Hypervisor status, allowing users to verify kernel configuration across the fleet.

@anokfireball anokfireball force-pushed the feature/report-kernel-parameters branch 3 times, most recently from 6a442c6 to 8823f37 Compare February 20, 2026 14:19
@anokfireball anokfireball marked this pull request as ready for review February 20, 2026 14:20
@notandy notandy self-requested a review February 20, 2026 16:57
Copy link
Contributor

@notandy notandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure systemd provides kernel commandline via DBUS

@fwiesel
Copy link
Contributor

fwiesel commented Feb 20, 2026

I do not think it is a good idea to block this change based on that. The /proc/cmdline is world-readable, it really can't get much easier and robust than reading that file.

@notandy
Copy link
Contributor

notandy commented Feb 20, 2026

I do not think it is a good idea to block this change based on that. The /proc/cmdline is world-readable, it really can't get much easier and robust than reading that file.

I don't think we agree on this.

Anyway, I couldn't find a method or property in default DBUS services that exposes the cmdline. Also proc/cmdline seems to be mounted by default in every container, so this pr just needs an rebase.

@notandy notandy self-requested a review February 20, 2026 18:54
This enables the operator to report kernel boot parameters in the
Hypervisor status, allowing users to verify kernel configuration
across the fleet.
@anokfireball anokfireball force-pushed the feature/report-kernel-parameters branch from 8823f37 to 1631fd4 Compare February 23, 2026 14:20
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/kvm-node-agent/internal/controller 41.28% (+1.52%) 👍
github.com/cobaltcore-dev/kvm-node-agent/internal/kernel 94.74% (+94.74%) 🌟

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/kvm-node-agent/internal/controller/hypervisor_controller.go 59.17% (+1.27%) 120 (+6) 71 (+5) 49 (+1) 👍
github.com/cobaltcore-dev/kvm-node-agent/internal/kernel/interface_mock.go 91.67% (+91.67%) 12 (+12) 11 (+11) 1 (+1) 🌟
github.com/cobaltcore-dev/kvm-node-agent/internal/kernel/parameters.go 100.00% (+100.00%) 7 (+7) 7 (+7) 0 🌟

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/cobaltcore-dev/kvm-node-agent/internal/controller/hypervisor_controller_test.go
  • github.com/cobaltcore-dev/kvm-node-agent/internal/kernel/parameters_test.go

@anokfireball anokfireball merged commit cbdd928 into main Feb 23, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants