Draft
Conversation
…f v1alpha1.DecisionResult
…ndling and remove redundant test cases
…r external scheduler tests
| PipelineRef corev1.ObjectReference `json:"pipelineRef"` | ||
| // The Intent for this scheduling event. | ||
| Intent SchedulingIntent `json:"intent"` | ||
| } |
Member
There was a problem hiding this comment.
Note: this can be >1000 entries. Can you test when this would explode the kubernetes resource size limit? If we're orders of magnitude off (e.g. 50k entries are possible) this should be fine, or we should truncate the scheduling history in the controller and document this. E.g.
// SchedulingHistory provides the history of the observed resource.
// For example, this can be the (re-)schedulings of a virtual machine
// over time. Entries are always truncated to 100 elements to stay
// within the kubernetes resource size limits. Check `HistoryLength`
// for the untruncated number of events recorded for this resource.
SchedulingHistory []SchedulingHistoryEntry `json:"schedulingHistory,omitempty"`
Member
PhilippMatthes
left a comment
PhilippMatthes
left a comment
There was a problem hiding this comment.
Just a side note since I stumbled apon it again, I think we should remove the visualizer with this PR as well
Contributor
Test Coverage ReportTest Coverage 📊: 67.2% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Refactored Decision CRD architecture
Simplified controller architecture
Filter-Weigher pipeline controllers now use reconciliation loop for Pipeline/Knowledge changes instead of separate event handlers
Knowledge changes now trigger reconciliation of all affected pipelines via
GetAllPipelineReconcileRequestsAdded decision queue with background worker for async Decision updates without blocking API responses
Explanation system redesign
ToDo's