Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4283 +/- ##
=======================================
Coverage 97.42% 97.42%
=======================================
Files 891 892 +1
Lines 26098 26116 +18
Branches 9435 9437 +2
=======================================
+ Hits 25426 25444 +18
- Misses 629 666 +37
+ Partials 43 6 -37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
11eabf8 to
5573f53
Compare
e739e19 to
7972a95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR restores legacy behavior in Select, Multiselect and Autosuggest when
expandToViewport=true.Current behavior: When
expandToViewport=true, the dropdown’s width scales up to thexssbreakpoint but can be smaller than the trigger if the content inside is narrower.Expected behavior: When
expandToViewport=true, the dropdown’s width matches the width of the trigger element, but only up to thexssbreakpoint. This behavior is consistent with the legacy implementation (seeAWSUI-19898).We were missing a specific test case where the dropdown content is narrower than the trigger, which caused this behavior change to slip through in #4239.
Related links, issue #, if available: n/a
How has this been tested?
Pipeline is green (will add tests for that specific scenario).
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.