fix: Underlined component styling when nested in Inline Tokens#4278
Open
fix: Underlined component styling when nested in Inline Tokens#4278
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4278 +/- ##
=======================================
Coverage 97.42% 97.42%
=======================================
Files 891 892 +1
Lines 26098 26106 +8
Branches 9435 9437 +2
=======================================
+ Hits 25426 25434 +8
Misses 629 629
Partials 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
avinashbot
reviewed
Feb 25, 2026
Member
avinashbot
left a comment
There was a problem hiding this comment.
No comments on the code itself, but did we run this by the team?
I could go either way on this personally. It seems like we're creating a kind of implicit API contract here... but maybe since it's just a styling thing it's nbd?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses a case where components using underlines need a different spacing offset between the underline and text when nested inside Inline Tokens. In this PR a Context/Provider is added to Token and used inside Link and Popover to adjust the underline spacing when in the Token context with
variant="inline"Spacing has been reviewed by Design.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.