Skip to content

fix: Underlined component styling when nested in Inline Tokens#4278

Open
ernst-dev wants to merge 2 commits intomainfrom
dev-v3-ernstka-inline-token-underline-styling
Open

fix: Underlined component styling when nested in Inline Tokens#4278
ernst-dev wants to merge 2 commits intomainfrom
dev-v3-ernstka-inline-token-underline-styling

Conversation

@ernst-dev
Copy link
Member

Description

Addresses a case where components using underlines need a different spacing offset between the underline and text when nested inside Inline Tokens. In this PR a Context/Provider is added to Token and used inside Link and Popover to adjust the underline spacing when in the Token context with variant="inline"

Spacing has been reviewed by Design.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Feb 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.42%. Comparing base (5cfcc6d) to head (002321a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4278   +/-   ##
=======================================
  Coverage   97.42%   97.42%           
=======================================
  Files         891      892    +1     
  Lines       26098    26106    +8     
  Branches     9435     9437    +2     
=======================================
+ Hits        25426    25434    +8     
  Misses        629      629           
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@avinashbot avinashbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comments on the code itself, but did we run this by the team?

I could go either way on this personally. It seems like we're creating a kind of implicit API contract here... but maybe since it's just a styling thing it's nbd?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants