chore: add dev warning for deprecated fragment flattening#4277
Open
chore: add dev warning for deprecated fragment flattening#4277
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4277 +/- ##
=======================================
Coverage 97.42% 97.42%
=======================================
Files 891 892 +1
Lines 26098 26102 +4
Branches 9435 9434 -1
=======================================
+ Hits 25426 25430 +4
- Misses 629 666 +37
+ Partials 43 6 -37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pan-kot
reviewed
Feb 20, 2026
|
|
||
| export function flattenChildren(children: ReactNode, componentName?: string): ReactNode[] { | ||
| const versionString = React.version?.split('.')[0]; | ||
| const majorVersion = versionString ? parseInt(versionString, 10) : NaN; |
Member
There was a problem hiding this comment.
nit: I would extract React version getter into a util
pan-kot
reviewed
Feb 20, 2026
| return Children.toArray(children).reduce((acc: ReactNode[], node, nodeIndex) => { | ||
| if (isFragmentWithChildren(node)) { | ||
| if (componentName) { | ||
| warnOnce( |
pan-kot
reviewed
Feb 23, 2026
| ); | ||
| }); | ||
|
|
||
| it('does not warn when no componentName is provided', () => { |
Member
There was a problem hiding this comment.
is there a use case for calling the util w/o component name?
Member
Author
There was a problem hiding this comment.
Yes, we use it in pages/flashbar/runtime-content.page.tsx here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR inlines the library react-keyed-flatten-children@^2.2.1 and adds react-is: ^18.2.0 to package.json (the version for react-is was checked against the one used by react-keyed-flatten-children from here). And, it adds dev warning when fragments are being flattened.
Tested by: Running through my pipeline and running Dry Run Build
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.