Fix NoMethodError when diffing manifest for new apps with features#4941
Merged
philippthun merged 1 commit intocloudfoundry:mainfrom Mar 20, 2026
Merged
Conversation
The remove_unspecified_app_features method was called without checking if existing_value was present, causing a NoMethodError when applying a manifest with features for a new (non-existing) app: undefined method `slice!' for nil:NilClass .../space_diff_manifest.rb:220:in `remove_unspecified_app_features'
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Mar 20, 2026
Changes in cloud_controller_ng:
- Fix NoMethodError when diffing manifest for new apps with features
PR: cloudfoundry/cloud_controller_ng#4941
Author: Philipp Thun <philipp.thun@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
remove_unspecified_app_featuresmethod was called without checking ifexisting_valuewas present, causing aNoMethodErrorwhen applying a manifest with features for a new (non-existing) app:I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests