Add --pidfile support with signal-aware cleanup to cloudflared access…#1599
Open
Enginerd-2019 wants to merge 1 commit intocloudflare:masterfrom
Open
Add --pidfile support with signal-aware cleanup to cloudflared access…#1599Enginerd-2019 wants to merge 1 commit intocloudflare:masterfrom
Enginerd-2019 wants to merge 1 commit intocloudflare:masterfrom
Conversation
… tcp Add --pidfile flag to the access tcp subcommand (also applies to rdp, ssh, and smb aliases). This writes the process ID to a file after startup and removes it on exit. Signal handling (SIGTERM/SIGINT) ensures the PID file is cleaned up when the process is killed, not just on graceful shutdown. Includes unit tests for writePidFile and removePidFile. Closes cloudflare#723
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
--pidfileflag tocloudflared access tcp(and its aliases:rdp,ssh,smb).defer) and signals (SIGTERM/SIGINT)--pidfilesupportwritePidFileandremovePidFileCloses #723
How it differs from #1579
This PR improves on the existing attempt (#1579) with:
kill <pid>defer removePidFile()covers error exits and normal shutdownscarrier_test.gowith tests for write, cleanup, and error handlingTest plan
make fmt-checkpassesmake lintpassesmake testpasses (including new unit tests)./cloudflared access tcp --helpshows the--pidfileflagkill