Closed
Conversation
Author
|
This would be really nice |
Author
|
@tsjnsn For the moment, I published a single version of a UMD build of this package here: https://www.npmjs.com/package/@jrop/hyperx I still would like to have this merged though :/ |
| "test": "tape test/*.js", | ||
| "coverage": "covert test/*.js" | ||
| "coverage": "covert test/*.js", | ||
| "prepack": "webpack" |
Member
There was a problem hiding this comment.
using browserify with tinyify seems simpler than placing a webpack config file in the root just for umd:
"scripts": {
"prepublish": "browserify -s hyperx -p tinyify index.js -o dist/hyperx.js"
}and a bit more in line with other choo-adjacent projects :)
Member
|
personally i'm cool with publishing UMD builds. I know not everyone in the choojs org likes em tho. you can also use https://wzrd.in/standalone/hyperx which browserifies a UMD build on the fly. |
Contributor
|
the ecma world has chosen es modules for the module standard. closing this in favor of #85 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publishing as a UMD bundle allows for easy use in HTML pages via unpkg:
This change is completely backward-compatible and supports:
require('hyperx')still works)window.hyperxwhen included via a<script>tagThis mirrors how React is publishing their module as well. See:
https://unpkg.com/react@16.2.0/cjs/