refactor: TableSettings based on @tanstack/react-table integration from react-science#3994
refactor: TableSettings based on @tanstack/react-table integration from react-science#3994
TableSettings based on @tanstack/react-table integration from react-science#3994Conversation
@tanstack/react-table integration@tanstack/react-table integration
Deploying nmrium with
|
| Latest commit: |
081fa1e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d8af16c6.nmrium.pages.dev |
| Branch Preview URL: | https://3989-unify-table-form.nmrium.pages.dev |
@tanstack/react-table integrationTable with @tanstack/react-table integration
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
edda027 to
c7bb17a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
65e24de to
fcc4b7a
Compare
|
Hi, I think this PR is in a good state for a first review.
@targos @Sebastien-Ahkrin I would have your feedbacks on the look of the table / interactions, and the API itself. The API of
I did not give a try to sort yet, but it should be possible because react-science bind |
This comment was marked as resolved.
This comment was marked as resolved.
targos
left a comment
There was a problem hiding this comment.
I implemented tdStyle column metadata with getTdProps (I will implement it directly in react-science if you agree)
SGTM
I implemented an empty state, I don't know if it should be implemented in react-science also.
Probably makes sense to add in react-science
This comment was marked as outdated.
This comment was marked as outdated.
This reverts commit 08f1de6.
feat: infoblock rows can be reordered
dc95692 to
f9106d9
Compare
25c0043 to
69cdf4f
Compare
Table with @tanstack/react-table integrationTableSettings based on @tanstack/react-table integration from react-science
Unify table usage with
TableSettingsandTableSectionCloses: #3989