Skip to content

feat: add webserver guardrail for playwright checks [tra-1789]#1196

Merged
sorccu merged 6 commits intomainfrom
pilar/tra-1789-add-cli-guardrails-to-common-errors-webserver
Jan 29, 2026
Merged

feat: add webserver guardrail for playwright checks [tra-1789]#1196
sorccu merged 6 commits intomainfrom
pilar/tra-1789-add-cli-guardrails-to-common-errors-webserver

Conversation

@pilimartinez
Copy link
Member

@pilimartinez pilimartinez commented Jan 19, 2026

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

Detect webServer configuration in Playwright configs and show a helpful warning message with remediation guidance. This warning triggers if theres a webServer in the playwright.config and theres no --include flag in the pw-test command.

image

@pilimartinez
Copy link
Member Author

@sorccu Please take a minute to check the changes, this is the first guardrail I'm adding so it may be lacking things that a more experienced eye like yours could catch. This was tested manually on my side and also added a test.

@pilimartinez pilimartinez marked this pull request as draft January 19, 2026 16:09
@pilimartinez pilimartinez removed the request for review from sorccu January 19, 2026 17:07
@pilimartinez pilimartinez marked this pull request as ready for review January 21, 2026 14:52
hwartig
hwartig previously approved these changes Jan 23, 2026
Copy link
Contributor

@hwartig hwartig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pilimartinez pilimartinez requested a review from sorccu January 28, 2026 14:43
@hwartig hwartig self-requested a review January 29, 2026 10:57
Copy link
Contributor

@hwartig hwartig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sorccu sorccu merged commit d32f2e1 into main Jan 29, 2026
3 checks passed
@sorccu sorccu deleted the pilar/tra-1789-add-cli-guardrails-to-common-errors-webserver branch January 29, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments